Fixing linking on macOS - iconv lib would not get picked up

[mauritium]

Fixing linking on macOS - iconv lib would not get picked up by linker, need to add -liconv explicitly where needed

[sirainen]

This library isn't wanted/needed with Linux. So it should be somehow conditionally added by a configure check.

[mauritium]

Aah, I didn't know that. Unfortunately, I have little knowledge of autoconf/automake. My first impression, however, is that src/lib-charset/charset-iconv.c is compiled unconditionally, and it includes `<iconv.h> unconditionally here:

core/src/lib-charset/charset-iconv.c

Line 7 in 06af539

#include <iconv.h>

. This means even on Linux? If there was a config flag for iconv, we could of course make it conditional, but I don't see it unfortunately :(

I regret this is beyond my expertise, and I also lack the context/background on what's needed for dovecot specifically.

The fact is, however, that in its current form the code fails to build on macOS because somehow iconv code is compiled but not linked with the iconv library.

[cmouse]

We'll take a look on how to fix this.

[mauritium]

Thanks! I notice that

core/src/lib-charset/test-charset.c

Line 63 in 06af539

#ifdef HAVE_ICONV

has a reference to HAVE_ICONV, but this does not seem to be defined anywhere.

[cmouse]

Fixed with 61307c071d79cdc0a696d32c8d8f5047bd1e82e0^...77fe3ca