-
Notifications
You must be signed in to change notification settings - Fork 1
This PR adds CoppeliaSim interface classes for serial robots #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
LBR4p_DH_alpha | ||
LBR4p_DH_type]; | ||
|
||
kin = DQ_SerialManipulatorDH(LBR4p_DH_matrix, 'standard'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ffasilva, the constructor `DQ_SerialManipulatorDH(DH_matrix, 'standard') is deprecated. Please use the modern constructor of the class.
LBR4p_DH_d = [0.200, 0, 0.4, 0, 0.39, 0, 0]; | ||
LBR4p_DH_a = [0, 0, 0, 0, 0, 0, 0]; | ||
LBR4p_DH_alpha = [pi/2, -pi/2, pi/2, -pi/2, pi/2, -pi/2, 0]; | ||
LBR4p_DH_type = double(repmat( ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ffasilva the class member DQ_SerialManipulatorDH.JOINT_ROTATIONAL
is deprecated. Please use the class DQ_JointType
.
arm_DH_alpha; | ||
arm_DH_type]; | ||
|
||
arm = DQ_SerialManipulatorDH(arm_DH_matrix, 'standard'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my previous comment https://github.com/dqrobotics/matlab-interface-coppeliasim-zmq/pull/3/files#r2347385632
arm_DH_a = [0.033, 0.155, 0.135, 0, 0]; | ||
arm_DH_alpha = [pi/2, 0, 0, pi/2, 0]; | ||
arm_DH_type = double(repmat( ... | ||
DQ_SerialManipulatorDH.JOINT_ROTATIONAL, 1, 5)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my previous comment https://github.com/dqrobotics/matlab-interface-coppeliasim-zmq/pull/3/files#r2347397941
Hi @juanjqo, Thanks for the review! The problem with your request is that
Please let me know what you think is best. My thoughts are that since the ZMQ interface now exists in its own independent repository, it should support the Kind regards, Quick P.S. editing: This relates to this earlier discussion. In brief, we should avoid forcing users to download a non-release version of DQ Robotics to have some other part of the library working. |
@ffasilva |
…Q' to match C++ implementation
Dear @dqrobotics/developers,
This PR implements the classes
DQ_SerialCoppeliaSimRobotZMQ
,LBR4pCoppeliaSimRobotZMQ
, andYouBotCoppeliaSimRobotZMQ
. They are the ZMQ equivalent of the old V-REP interface classes DQ_SerialVrepRobot, LBR4pVrepRobot, and YouBotVrepRobot, respectively.DQ_SerialCoppeliaSimRobotZMQ
inherits from DQ_CoppeliaSimRobot and implements all the abstract methods required by it, whereasLBR4pCoppeliaSimRobotZMQ
andYouBotCoppeliaSimRobotZMQ
are concrete instantiations ofDQ_SerialCoppeliaSimRobotZMQ
to CoppeliaSim's KUKA LBR4+ and youBot robots, respectively.To test my implementations, I updated the old simulation-ram-paper to work with the new ZMQ interface. This simulation is available in 14.
Please let me know what you think of it.
Kind regards,
Frederico