Skip to content

Remove thread_local in dllexported function #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove thread_local in dllexported function #1990

wants to merge 1 commit into from

Conversation

StableAgOH
Copy link

Fix #1845.

@StableAgOH StableAgOH force-pushed the remove-thread_local branch from 72488fd to f63cf49 Compare May 4, 2025 09:10
@StableAgOH
Copy link
Author

@an-tao CI was passed in my repository. Request for re-run.

@an-tao an-tao requested a review from marty1885 May 10, 2025 12:56
@marty1885
Copy link
Member

@StableAgOH Can you benchmark the performance difference? The reason for thread_local was to buffer some randomness generated from the random API. Random can have a high overhead per call. thread_local allows extra randomness be reused. (static does not work as the random function must be thread safe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marty1885 marty1885 Awaiting requested review from marty1885

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not build as shared library
2 participants
@StableAgOH @marty1885