Skip to content

Conversation

@maxyz
Copy link
Contributor

@maxyz maxyz commented Nov 9, 2024

Hypothesis is now setting two entries for the Callables strategies, and then it prefers the one using the type origin. While returns lookup for the first set and replaces the strategy, starting with the one without the type origin.

This only changes the callable strategy search order to match hypothesis, alternatively we could set both.

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Hypothesis is now setting two entries for the Callables strategies, and then it
prefers the one using the type origin. While returns lookup for the first set
and replaces the strategy, starting with the one without the type origin.

This only changes the callable strategy search order to match hypothesis,
alternatively we could set both.
@codecov
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (82ef3ef) to head (6e26ec9).
Report is 239 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1956   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        81    +1     
  Lines         2485      2540   +55     
  Branches       437       447   +10     
=========================================
+ Hits          2485      2540   +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sobolevn sobolevn merged commit 66bec02 into dry-python:master Nov 9, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants