Update for work state to 2023.08.01 by den-patrakeev · Pull Request #122 · dryark/stf_ios_support

den-patrakeev · 2023-08-09T16:54:58Z

Fix error by:
libimobiledevice-glue (new formula) Homebrew/homebrew-core#87059
Homebrew installation of libimobiledevice from HEAD fails with missing package libimobiledevice-glue-1.0 libimobiledevice/libimobiledevice#1217
https://githubhelp.com/devicefarmer/stf_ios_support/issues/37
https://cdmana.com/2021/07/20210721023059534z.html
Failed setup on Mac OS Catalina #100
Failed setup on Mac OS Catalina #100
/bin/sh: ./Scripts/bootstrap.sh: No such file or directory #95
https://github.com/mbilbiesi/stf_ios_support/pull/1/files
https://juejin.cn/post/6985818094794965006#heading-6
Failed setup on Mac OS Catalina #100
/bin/sh: ./Scripts/bootstrap.sh: No such file or directory #95
https://github.com/mbilbiesi/stf_ios_support/pull/1/files
random mismash of issues #24
small refactoring
add work instruction for deploying

@koral-- Hi!
I don't see anymore repository: https://github.com/DeviceFarmer/stf_ios_support for create PR(

coordinator/coordinator.go

nanoscopic

Mostly looks fine. Have a few questions but I don't see anything here that is functionally problematic.

I'm not clear on why view_log and wda_wrapper have been moved into subdirectories, but I also have no issue if that is done.

The documentation changes are quite messy, and a lot of that documentation needs to be cleaned up / revamped. It was though in bad shape to begin with, so I'm not really concerned.

Are there PRs in other repos associated with this PR?

nanoscopic · 2023-08-11T10:39:05Z

coordinator/go.mod

 module coordinator.go

-go 1.12
+go 1.16


I don't see any issue with updating the base requirement to 1.16. I am curious if there is any specific need to do so?

This file was generated on version 16, left it as it is.
Reason - 1.12 is deprecated and more unavailable in Homebrew:
https://formulae.brew.sh/formula/go#default

1.16 now the most wounding available version

nanoscopic · 2023-08-11T10:41:18Z

coordinator/proc_device_unit.go

    }
    o.procName = "stf_device_ios"
-    o.binary   = "/usr/local/opt/node@12/bin/node"
+    o.binary   = "/usr/local/opt/node@14/bin/node"


Does latest STF now require node 14? I set it this way just because it was what was installed on my machine. Really this should be changed to auto-detect which Node is installed and use the latest acceptable version. ( which may not be the latest if STF itself doesn't support the latest. )

node@12 now is more unavailable in Homebrew:
https://formulae.brew.sh/formula/node#default

For this reason, the version is raised to the minimum accessible and check working provider on node@14.

Current used version NodeJS in STF view 17:
https://github.com/DeviceFarmer/stf/blob/master/Dockerfile-debian-x86_64#L29

I think that updating the version of NodeJs is actually better done as part of a separate task. There is a PR about this:
#118

nanoscopic · 2023-08-11T10:42:22Z

docs/DEPLOYMENT.md

+# Deployment
+
+## Relevance
+This instruction actual on 2023/08/09


What is this date here for? People can see when the docs were last updated by looking at the commit date.

nanoscopic · 2023-08-11T10:42:57Z

docs/DEPLOYMENT.md

+This instruction actual on 2023/08/09
+
+## Tested working configuration
+- PC: MacMini 2018 (x86_64)


I don't see how the physical hardware matters. It would not change anything.

nanoscopic · 2023-08-11T10:44:01Z

docs/DEPLOYMENT.md

+
+## Tested working configuration
+- PC: MacMini 2018 (x86_64)
+- OS: MacOS Ventura 13.5


No part of MacOS is used. MacOS in the sense of the repo is only used as a Linux environment really that has usbmuxd running. In MacOS case it is the Apple usbmuxd implementation, so this could make some small difference, but I don't think is worth mentioning.

The MacOS version can affect the available Homebrew packages and the available XCode version.
For this reason, it is indicated

Now libusbmuxd dont compile on MacOS 12 and requires MacOS > 13.0 and new XCode.

Fix info

nanoscopic · 2023-08-11T10:46:13Z

docs/DEPLOYMENT.md

+- PC: MacMini 2018 (x86_64)
+- OS: MacOS Ventura 13.5
+- IDE: XCode 14.3.1
+- Mobile devices: iPhone and iPad different years with iOS versions: 14.1, 14.2, 14.6, 14.7, 15.0, 15.4.1, 16.6


A very wide set of device versions beyond this has been tested. It long since became irrelevant to list which versions have been tested. If versions don't work they should just have an open issue.

nanoscopic · 2023-08-11T10:46:55Z

docs/DEPLOYMENT.md

+    1. Click `+` in the lower left corner
+    1. Select `Apple Development`
+1. Install [Homebrew](https://docs.brew.sh/Installation)
+1. Install Python 2.7 from MacPorts


I don't think I ever said this. Why install Python from MacPorts?

Python 3 is default from MacOS 11:
https://developer.apple.com/documentation/macos-release-notes/macos-catalina-10_15-release-notes#Deprecations

To use Python 2.7, you need to install it separately. Homebrev does not support the installation of Python, so MacPorts remain the most convenient way.

nanoscopic · 2023-08-11T10:48:08Z

docs/DEPLOYMENT.md

+1. Download actual profiles for device by Xcode or TestFlight:
+https://docs.fastlane.tools/actions/sigh/
+
+## 4. Prepare dependenses on build machine


MIsspelling. It is spelled "dependencies"

Thanks, fix it

nanoscopic · 2023-08-11T10:49:12Z

docs/DEPLOYMENT.md

+
+In Homebrew no formulae for it: https://github.com/Homebrew/homebrew-core/pull/87059
+
+1. Resolve by: https://github.com/libimobiledevice/libimobiledevice/issues/1217


Is this pile of junk really needed??

nanoscopic · 2023-08-11T10:50:20Z

docs/DEPLOYMENT.md

+    }
+    ```
+
+1. Fix [error](https://github.com/DeviceFarmer/stf_ios_support/issues/100) in repos `ios_video_pull`


This should be addressed by having a mentioned PR for that repo also that gets accepted along with this one.

fix doc
dryark/ios_video_pull#2

den-patrakeev · 2023-08-14T14:13:54Z

Mostly looks fine. Have a few questions but I don't see anything here that is functionally problematic.

I'm not clear on why view_log and wda_wrapper have been moved into subdirectories, but I also have no issue if that is done.

The documentation changes are quite messy, and a lot of that documentation needs to be cleaned up / revamped. It was though in bad shape to begin with, so I'm not really concerned.

Are there PRs in other repos associated with this PR?

Add new PR by comment: dryark/ios_video_pull#2

den-patrakeev · 2023-08-21T15:19:52Z

@nanoscopic hi!
Please get acquainted.

den-patrakeev · 2023-08-29T08:09:53Z

@nanoscopic remind me of PR

nm-free · 2023-12-11T10:00:40Z

@nanoscopic hello

When will it be reviewed and merged?

volvoeacs · 2024-01-08T06:16:06Z

@nanoscopic , I am trying to setup iOS provider in Mac mini m2 , Mac Samoa OS. Do I need to take care of anything extra to make it work with arm based Mac system?

den-patrakeev added 6 commits August 2, 2023 19:40

fix error build on 2023.08.01 and small refactoring

972084f

fix version NodeJS

f65baa6

Fix use version Python for script

04acd67

fix versio NodeJS in code

39442d7

fix version golang

f82b92e

add new instruction for build and deployment

60a8df0

koral-- reviewed Aug 9, 2023

View reviewed changes

coordinator/coordinator.go Outdated Show resolved Hide resolved

fix by comment to PR

c2a5f4c

nanoscopic reviewed Aug 11, 2023

View reviewed changes

den-patrakeev added 4 commits August 14, 2023 11:37

fix docs by comment to PR

800be76

fix misspelling by comment to PR

721ca00

fix by comment to PR

261b39e

fix by comment to PR

453744c

den-patrakeev mentioned this pull request Aug 14, 2023

Fix error build dryark/ios_video_pull#2

Open

fix by comment to PR

3661aa9

den-patrakeev requested a review from nanoscopic August 14, 2023 14:12

den-patrakeev mentioned this pull request Aug 14, 2023

Error execute "make clone" or "make all" #119

Open


		In Homebrew no formulae for it: https://github.com/Homebrew/homebrew-core/pull/87059

		1. Resolve by: https://github.com/libimobiledevice/libimobiledevice/issues/1217

Conversation

den-patrakeev commented Aug 9, 2023

Uh oh!

Uh oh!

nanoscopic left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

den-patrakeev Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

den-patrakeev commented Aug 14, 2023

Uh oh!

den-patrakeev commented Aug 21, 2023

Uh oh!

den-patrakeev commented Aug 29, 2023

Uh oh!

nm-free commented Dec 11, 2023

Uh oh!

volvoeacs commented Jan 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nanoscopic left a comment •

edited

Loading

den-patrakeev Aug 14, 2023 •

edited

Loading