Fix for autocomplete things beginning with / and make it work still for things without /#179
Open
mattiasrunge wants to merge 2 commits intodthree:masterfrom
Open
Fix for autocomplete things beginning with / and make it work still for things without /#179mattiasrunge wants to merge 2 commits intodthree:masterfrom
mattiasrunge wants to merge 2 commits intodthree:masterfrom
Conversation
Owner
|
Thanks. Can you add a test for this? |
Contributor
|
@mattiasrunge You around to add a test? |
Author
|
Could maybe do it, but don't have time currently so it will be a while before I can help, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When returning an array of matches to autocomplete which begins with / it ignored the result.
If trying to autocomplete "/t" with result [ "/test/" ] the match was discarded.
Though trying to autocomplete "t" with [ "test/" ] would give the expected result.
This fix makes both cases work.