Draft of changing unsupported minimist to yargs-parser#322
Open
zyuhel wants to merge 5 commits intodthree:masterfrom
Open
Draft of changing unsupported minimist to yargs-parser#322zyuhel wants to merge 5 commits intodthree:masterfrom
zyuhel wants to merge 5 commits intodthree:masterfrom
Conversation
milesj
reviewed
Aug 15, 2018
package.json
Outdated
| @@ -61,7 +61,8 @@ | |||
| "minimist": "^1.2.0", | |||
Contributor
There was a problem hiding this comment.
Can you remove minimist while you're at it.
Author
There was a problem hiding this comment.
Removed it, should i add a test regarding issue #304?
milesj
approved these changes
Aug 18, 2018
Author
|
Sorry, forgot main file. It has option "minimist" i haven't changed this option name, due to backward-compatibility. Not sure should it be changed or not. |
milesj
approved these changes
Sep 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should help resolve issue #304 , may be some tests should be added.