Typo fixes #4 #774
Typo fixes #4 #774
Conversation
| const client = new DuneClient(DUNE_API_KEY ?? ""); | ||
| const queryID = 1215383; | ||
| const params = { | ||
| query_parameters = [ |
There was a problem hiding this comment.
don't think this needs to be changed
There was a problem hiding this comment.
this would be invalid javascript then.
There was a problem hiding this comment.
don't think this needs to be changed
| icon="road-bridge" | ||
| href="/api-reference/projects/endpoint/linea_lxp" | ||
| > | ||
| Get LXP balance for wallet, along with social and onchain behavior stats |
|
|
||
| url := "https://api.dune.com/api/v1/query/{queryId}" | ||
|
|
||
| payload := strings.NewReader("{\n \"query_id\": 1252207,\n ,\n \"query_sql\": \"{{blockchain}}.transactions WHERE to = {{address}} AND block_number > {{blocknumber}}\"}") |
There was a problem hiding this comment.
i think we can keep the \n and also add the SELECT * FROM
There was a problem hiding this comment.
The ,\n makes this invalid json. But yes the query_sql should have select * from.
There was a problem hiding this comment.
yeah. But it is prob fine to leave. Should be non-consequential and would take more effort to undo.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| --- | ||
| title: 'Private Query' | ||
| openapi: 'POST /v1/query/{queryId}/private' | ||
| openapi: 'GET /v1/query/{queryId}/private' |
There was a problem hiding this comment.
Bug: Inconsistent HTTP Method for State Change
The OpenAPI specification for the private query endpoint is changed from POST to GET. Making a query private is a state-changing operation that should use POST. This change is inconsistent with other similar endpoints (archive, unarchive, unprivate) which are correctly defined as POST, and are even being updated to POST in this same diff. This could lead to incorrect API documentation or failed API calls.
| "X-DUNE-API-KEY": "<x-dune-api-key>" | ||
| } | ||
|
|
||
| response = requests.request("POST", url, data=data, headers=headers) |
Fixes typos. See #770 for context