Skip to content

Port Avaiability. elixir_auth_google.ex #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Port Avaiability. elixir_auth_google.ex #147

wants to merge 9 commits into from

Conversation

fabricedge
Copy link

Case the user starts a project in port 4001 the "baseurl" it will be as https://example.com and not https:example.com:4001.

@fabricedge
port 443 as usable elixir_auth_google.ex
00f544b 
In my project i used port 443, so each time i was a trying to access it via this port the connection was blocked.
This solution mighty be simple but it works.
need to do: add error handler case server is using lets say port 4000 or 4001.
@fabricedge
Update elixir_auth_google.ex
bea6f33 
port 443 support
@fabricedge
Update elixir_auth_google.ex
bc7ce68 
Soo if the server starts using port 4001... its will only use the Scheme and Port cause most of the time the server its not being acessed with an port in the URL.
@fabricedge
Copy link
Author

those 2 first commits are thrash.

@nelsonic
Copy link
Member

nelsonic commented Jun 2, 2025

This PR is promising. 👍
Seems like a good feature to add for people who need the alternative TCP Port. 💭
Please check why build/test fails and if you need help LMK. 👌

@nelsonic nelsonic added enhancement New feature or request elixir Pull requests that update elixir code labels Jun 2, 2025
@fabricedge
Copy link
Author

last commit its working on my localnet and https website.

@nelsonic
Copy link
Member

nelsonic commented Jul 2, 2025

The Build passes. ✅

https://github.com/dwyl/elixir-auth-google/actions/runs/16018724162/job/45196435416?pr=147#step:6:64
image

However the test coverage decreases by the 4.2% corresponding to the new lines added by the PR. 📉
We could fairly easily get this back up to 100% coverage with a couple of simple tests. 🧪 💭

fabricedge
fabricedge commented Jul 3, 2025
View reviewed changes
Copy link
Author

@fabricedge fabricedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first time using this.

@nelsonic
Copy link
Member

nelsonic commented Jul 4, 2025

Hi @fabricedge 👋
Apologies, didn't realise you're relatively new to using Elixir ... 🙃
Do you need some assistance on writing tests/docs for this PR? 📝
We are keen to get the feature merged. 👌

@fabricedge
Copy link
Author

Hi @fabricedge 👋 Apologies, didn't realise you're relatively new to using Elixir ... 🙃 Do you need some assistance on writing tests/docs for this PR? 📝 We are keen to get the feature merged. 👌

Hi! I wanted to know what stopped the completition of the 100% test. Is it related to the "elixir_auth_google_test.exs" file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
elixir Pull requests that update elixir code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabricedge @nelsonic