Feature/issue 71 crud for prompt suggestions#92
Draft
schramm-joboo wants to merge 25 commits intomainfrom
Draft
Conversation
manuelkiessling
force-pushed
the
feature/issue-71-crud-for-prompt-suggestions
branch
from
3644e71 to
1dca197
Compare
Member
|
@schramm-joboo While it is not possible to directly enter linefeeds in the text area, it is still possible to "misuse" the text area by copy-and-pasting text with linefeeds into it, which results in one prompt being stored as multiple lines, making the project end up with multiple prompts. I think the logic that stores the prompt into the file must ensure that it does indeed not contain linefeeds (or replace linefeeds with space); it is not sufficient to prevent entry on the frontend. |
Member
|
@schramm-joboo Also, did you test how the feature behaves if a workspace project does not yet have a prompts file at all (or maybe not even a |
….com:dx-tooling/sitebuilder-webapp into feature/issue-71-crud-for-prompt-suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71