Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Wiz Scan Summary
|
| Scanner | Findings |
|---|---|
| 26 |
|
| - | |
| - | |
| - | |
| - | |
| - | |
| Total | 26 |
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.
| ), | ||
| }; | ||
| }); | ||
| case TradeFormType.SCALE: |
There was a problem hiding this comment.
Can also merge this logic with case TradeFormType.LIMIT with some conditionals but claude recommends keeping this a separate code path which i can also see the merit for
src/bonsai/forms/trade/errors.ts
Outdated
| (isShortTerm ? 0 : 1) + | ||
| (summary.tradePayload?.triggersPayloads?.filter((t) => t.placePayload != null).length ?? 0); | ||
| (summary.tradePayload?.triggersPayloads?.filter((t) => t.placePayload != null).length ?? 0) + | ||
| (summary.tradePayload?.scaleOrderPayloads?.length ?? 0); |
There was a problem hiding this comment.
would this result in 1 more order than actually expected?
Are all of the orders for a scaleOrder within the payload or just the ones after the initial order? Because we add a default 1 order on line 1081 here.
There was a problem hiding this comment.
oh yes you are right
src/bonsai/forms/trade/tradeInfo.ts
Outdated
| if (n < 2) return [startPrice]; | ||
| // Use n-1 gap weights to create non-linearly spaced prices | ||
| const { weights } = generateGeometricWeights(n - 1, skew); | ||
| const totalGapWeight = weights.reduce((a, b) => a + b, 0); |
There was a problem hiding this comment.
isn't this totalWeight returned from generateGeometricWeights? This is just re-summing items in the weights array?
Adds Scale order type
Screen.Recording.2026-03-09.at.10.53.42.AM.mov