Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dwjanus
force-pushed
the
dwj/eng-1921-datafeed-for-candles
branch
from
abc7898 to
de3de2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
tldr; Hardens the dydx TradingView datafeed to properly use TradingView's
countBackparameter and pass an explicit limit to candle API requests.src/lib/tradingView/dydxfeed/index.ts: ExtractcountBackfromperiodParamsand pass it through togetCandlesForDatafeed. Removes the TODO acknowledging this gap.-
src/hooks/useDydxClient.tsx: Accept countBack ingetCandlesForDatafeedRefactor while loop from
while (true)towhile (candlesInRange.length < countBack)— stops once TradingView has enough barsIssue
ENG-1921
Previously the while loop relied solely on time-range pagination with no explicit limit, and countBack was ignored entirely. With smaller API responses, the loop now properly paginates until countBack is fulfilled, ensuring TradingView always receives enough bars for chart rendering.