fix: replace pagination with createdBeforeOrAt keyset#2094
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dankim214
reviewed
Mar 10, 2026
| } | ||
|
|
||
| const allFills: RawSubaccountFill[] = [...fills, ...results.map((data) => data.fills).flat()]; | ||
| const newFills = fills.filter((fill: RawSubaccountFill) => !seenIds.has(fill.id)); |
Collaborator
There was a problem hiding this comment.
is the createdBeforeOrAt as a keyset not 100% reliable? as in we could still get overlap of fills between sequential requests?
| const seenIds = new Set<string>(); | ||
|
|
||
| for (let request = 0; request < DEFAULT_MAX_REQUESTS; request += 1) { | ||
| const createdBeforeOrAt = allFills.at(-1)?.createdAt ?? undefined; |
Collaborator
There was a problem hiding this comment.
?? undefined is redundant here prob
dankim214
approved these changes
Mar 10, 2026
dwjanus
force-pushed
the
dwj/eng-1927-dep-pagination-in-sub-fills
branch
from
be50a7b to
32d905d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Switch
requestAllAccountFillsfrom page-based to keyset paginationcreatedBeforeOrAtcursor pagination to reduce indexer loadcreatedAttimestamp of the last fetched fill as the cursor for each subsequent requestidto handle inclusive boundary overlaps across pagesRawSubaccountFill[]Issue
ENG-1927