Reworked 3d conformal and sequencing#885
Conversation
3d conformal now no longer errors out when used together with sequencing, the issue here was the inconsonant number of bixels in the stf, which is why the collapseStf function was added. Also changes to the sequencer were made to accomondate for example a beam with 0 weight vector.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #885 +/- ##
==========================================
+ Coverage 53.85% 54.05% +0.20%
==========================================
Files 308 309 +1
Lines 19939 20007 +68
==========================================
+ Hits 10738 10815 +77
+ Misses 9201 9192 -9 ☔ View full report in Codecov by Sentry. |
wahln
left a comment
There was a problem hiding this comment.
The tests are failing for some reason due to a missing "sum field".
…tests and updated secondary affected tests and code
|
There was a mistake in how the dij.numOf fields were interpreted which I fixed. I also used the opportunity to expand to collapse dijs to other modalities, which should work now. This affected some other tests and calculations which I fixed as well. |
|
Some other remarks:
Do you want to address this in this PR or in a following one? |
I think this can be adressed in this pull request, i am just a bit unsure how to best add this to the GUI, like how would we for example call the raywise mode for ions |
…uality in sequencing tests
|
The GUI thing could be secondary. We could for now just rename to 3D Conformal / SFUD. The ray mode does not need to be in the GUI for now. BTW: Did a few updates for the tests to run through, hopefully |
added a parameter "mode" that allows to select if the dij should be collapsed beam or raywise, also added this to the test
3d conformal now no longer errors out when used together with sequencing, the issue here was the inconsonant number of bixels in the stf, which is why the collapseStf function was added. Also changes to the sequencer were made to accomondate for example a beam with 0 weight vector.
this also reminded me that we should finish the work on the class based sequencers