Skip to content

Fix SoftwareSerial/SerialPIO inversion and build #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Fix SoftwareSerial/SerialPIO inversion and build #2423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1670476
Fix SoftwareSerial/SerialPIO inversion and build
earlephilhower Sep 6, 2024
5e6a544
Merge branch 'master' into kjlkjl
earlephilhower Sep 6, 2024
59f5144
Merge branch 'master' into kjlkjl
earlephilhower Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cores/rp2040/SerialPIO.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ void SerialPIO::begin(unsigned long baud, uint16_t config) {

digitalWrite(_tx, HIGH);
pinMode(_tx, OUTPUT);
gpio_set_outover(_tx, _invertTX);

pio_tx_program_init(_txPIO, _txSM, off, _tx);
pio_sm_clear_fifos(_txPIO, _txSM); // Remove any existing data
Expand All @@ -212,6 +211,7 @@ void SerialPIO::begin(unsigned long baud, uint16_t config) {
pio_sm_exec(_txPIO, _txSM, pio_encode_mov(pio_isr, pio_osr));

// Start running!
gpio_set_outover(_tx, _invertTX);
pio_sm_set_enabled(_txPIO, _txSM, true);
}
if (_rx != NOPIN) {
Expand Down
4 changes: 2 additions & 2 deletions cores/rp2040/SoftwareSerial.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ class SoftwareSerial : public SerialPIO {
};

void begin(unsigned long baud, uint16_t config) override {
setInvertTX(invert);
setInvertRX(invert);
setInvertTX(_invert);
setInvertRX(_invert);
SerialPIO::begin(baud, config);
}

Expand Down
1 change: 1 addition & 0 deletions keywords.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Dir KEYWORD1
File KEYWORD1
timeval KEYWORD1
time_t KEYWORD1
SoftwareSerial KEYWORD1

#######################################
# Methods and Functions (KEYWORD2)
Expand Down