Add support for MyMakers RP2350B board #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlephilhower
requested changes
Oct 1, 2025
There was a problem hiding this comment.
It looks like you've got a bad or very old version of the core for the patch. There should only be your single line addition to makeboards.py but you have changed/removed hundreds of lines with this PR, and 10,000 lines in boards.txt.
Please start from the latest core for your changes, and make sure to not edit boards.txt at all, it should be generated completely by makeboards.py but is showing hand edits in this PR, too.
earlephilhower
requested changes
Oct 2, 2025
earlephilhower
requested changes
Oct 2, 2025
|
I have deleted
เมื่อ พฤ. 2 ต.ค. 2568 เวลา 10:07 Earle F. Philhower, III <
***@***.***> เขียนว่า:
… ***@***.**** requested changes on this pull request.
------------------------------
In tools/json/mymakers_rp2350b.json
<#3164 (comment)>
:
> @@ -0,0 +1,56 @@
+{
This file should not be here, either.
—
Reply to this email directly, view it on GitHub
<#3164 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APWTIU7U7DGQNE7ZGA634R33VSJGHAVCNFSM6AAAAACH735NOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEOJRHA4TCOJVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
earlephilhower
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the MyMakers RP2350B board to the arduino-pico core. Changes include:
tools/makeboards.pyto generateboards.txtwith MyMakers RP2350Bjson/mymakers_rp2350b.jsonfor PlatformIOvariants/mymakers_rp2350b/pins_arduino.hfor pin mappingsREADME.mdto include MyMakers RP2350B in Supported BoardsPlease review and let me know if any changes are needed.