Skip to content

Use gmtime_r for multicore safety in HTTPClient #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

Use gmtime_r for multicore safety in HTTPClient #3170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2968f0e
Use gmtime_r for multicore safety in HTTPClient
earlephilhower Oct 2, 2025
80c1136
Merge branch 'master' into cql3
earlephilhower Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libraries/HTTPClient/src/HTTPClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1323,7 +1323,8 @@ void HTTPClient::setCookie(String date, String headerValue) {

// overwrite or delete cookie in/from cookie jar
time_t now_local = time(NULL);
time_t now_gmt = mktime(gmtime(&now_local));
struct tm timeinfo;
time_t now_gmt = mktime(gmtime_r(&now_local, &timeinfo));

bool found = false;

Expand Down Expand Up @@ -1353,7 +1354,8 @@ bool HTTPClient::generateCookieString(String *cookieString) {
return false;
}
time_t now_local = time(NULL);
time_t now_gmt = mktime(gmtime(&now_local));
struct tm timeinfo;
time_t now_gmt = mktime(gmtime_r(&now_local, &timeinfo));

*cookieString = "";
bool found = false;
Expand Down
Loading