Skip to content

add some optiomizations with react-hooks and es6 Map #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add some optiomizations with react-hooks and es6 Map #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1818071
refactor: add useMemo and useCallback to Editor components
awwit Sep 25, 2024
dc7db49
fix: improve types checking in calculateViewportRelatedStuff
awwit Sep 25, 2024
fffc8e2
fix: optimize Editor props
awwit Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/components/ComponentBuilder/ComponentBuilder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ function getCompiledSubcomponents(
let elements = compiledArray.map((compiledChild, index) =>
"_component" in compiledChild ? (
<EditableComponentBuilder
key={index}
compiled={compiledChild}
index={index}
length={compiledArray.length}
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/resourcesUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import type {
ExternalReferenceNonEmpty,
ExternalSchemaProp,
FetchOutputCompoundResources,
FetchResourceResolvedResult,
NonNullish,
ResponsiveValue,
} from "./types";
Expand Down Expand Up @@ -50,7 +51,7 @@ export function getResolvedExternalDataValue(
configId: string,
fieldName: string,
value: ExternalReferenceNonEmpty
) {
): FetchResourceResolvedResult<NonNullish> | undefined {
const externalReferenceLocationKey =
typeof value.id === "string" && value.id.startsWith("$.")
? value.id
Expand Down
Loading