fix(): show error message when conversation finished early #483
+49
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
==========================================
- Coverage 76.73% 76.72% -0.02%
==========================================
Files 594 594
Lines 18295 18299 +4
Branches 2816 2818 +2
==========================================
Hits 14039 14039
- Misses 3720 3724 +4
Partials 536 536
🚀 New features to boost your workflow:
|
weareoutman
force-pushed
the
steve/chat-panel
branch
from
1126e59 to
319816c
Compare
|
📐🤏 Size check result (d049e26...43c7770): Load all bricks together
Critical changes: None. See full changes
Load bricks by each packageCritical changes: None. See full changes
Load by each brickCritical changes:
See full changes
Critical details for brick advanced.general-cascader
Critical details for brick eo-directory-tree
Critical details for brick eo-search
Critical details for brick eo-time-range-picker
Critical details for brick form.general-input
Critical details for brick form.general-switch
|
Copilot finished reviewing on behalf of
weareoutman
November 26, 2025 03:33
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds error handling for conversations that are marked as finished prematurely while still in a working state. The changes detect this "early finished" condition and display an appropriate error message to the user.
Key changes:
- Added detection logic for "early finished" state (conversation finished but not in expected done/paused/input-required states)
- Display error message component when early finish is detected
- Updated AssistantMessage component to handle the early finished scenario with optional props
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
bricks/ai-portal/src/chat-stream/ChatStream.tsx |
Added NON_WORKING_STATES import, computed earlyFinished flag with replay check, conditionally rendered error message for early finished conversations |
bricks/ai-portal/src/chat-stream/AssistantMessage/AssistantMessage.tsx |
Made props optional to support early finished mode, added early finished error message constant, updated logic to hide typing indicator when finished |
bricks/ai-portal/src/chat-panel/index.tsx |
Reorganized imports, added NON_WORKING_STATES import, computed earlyFinished flag, conditionally rendered error message for early finished conversations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bricks/ai-portal/src/chat-stream/AssistantMessage/AssistantMessage.tsx
Outdated
Show resolved
Hide resolved
weareoutman
force-pushed
the
steve/chat-panel
branch
from
319816c to
ea28417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
依赖检查
组件之间的依赖声明，是微服务组件架构下的重要信息，请确保其正确性。
请勾选以下两组选项其中之一：
或者：
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG，请检查工作内容与提交信息是否相符，并在以下每组选项中都依次确认。
破坏性变更：
feat作为提交类型。BREAKING CHANGE: 你的变更说明。新特性：
feat作为提交类型。问题修复：
fix作为提交类型。杂项工作：
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动，例如修改注释、测试用例、开发文档等：
chore,docs,test等作为提交类型。