Skip to content

Steve/v3-data-attrs #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

Steve/v3-data-attrs #4813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a50b50
fix(): clear resolve cache before render incremental sub routes
weareoutman Oct 22, 2025
7a0dfae
fix(createRoot): support SYS.* usage
weareoutman Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/runtime/src/createRoot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ import {
isolatedTemplateRegistryMap,
registerIsolatedTemplates,
} from "./internal/IsolatedTemplates.js";
import { hooks } from "./internal/Runtime.js";

export interface CreateRootOptions {
portal?: HTMLElement;
Expand Down Expand Up @@ -151,6 +152,9 @@ export function unstable_createRoot(
formStateStoreMap: new Map<string, DataStore<"FORM_STATE">>(),
isolatedRoot,
unsafe_penetrate,
sys: {
...hooks?.auth?.getAuth(),
},
} as Partial<RuntimeContext> as RuntimeContext;

if (url) {
Expand Down
4 changes: 3 additions & 1 deletion packages/runtime/src/internal/Renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
asyncComputeRealPropertyEntries,
constructAsyncProperties,
} from "./compute/computeRealProperties.js";
import { resolveData } from "./data/resolveData.js";
import { clearResolveCache, resolveData } from "./data/resolveData.js";
import { asyncComputeRealValue } from "./compute/computeRealValue.js";
import {
TrackingContextItem,
Expand Down Expand Up @@ -944,6 +944,8 @@ async function legacyRenderBrick(
return false;
}

clearResolveCache();

const [
scopedRuntimeContext,
tplStateStoreScope,
Expand Down
10 changes: 5 additions & 5 deletions packages/runtime/src/internal/data/resolveData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ export async function resolveData(
) as Promise<UseProviderContractConf | null>,
]);

// `clearResolveCache` maybe cleared during the above promise being
// `clearResolveCache` maybe called during the above promise being
// fulfilled, so we manually mark it as stale for this case.
const renderId = resolveOptions?.renderId;
const stale = !!renderId && renderId !== _internalApiGetRenderId();
const isStale = () => !!renderId && renderId !== _internalApiGetRenderId();

const promise = resolveByProvider(
providerBrick,
Expand All @@ -94,7 +94,7 @@ export async function resolveData(
actualContractConf?.params ? actualContractConf : (actualArgs ?? []),
resolveOptions,
args,
stale
isStale
);

let { transform } = resolveConf;
Expand Down Expand Up @@ -137,7 +137,7 @@ export async function resolveByProvider(
args: unknown[] | UseProviderContractConf,
options?: ResolveOptions,
originalArgs?: unknown[],
stale?: boolean
isStale?: () => boolean
) {
let cacheKey: string;
try {
Expand Down Expand Up @@ -171,7 +171,7 @@ export async function resolveByProvider(
return brick[method](...finalArgs);
})();

if (!stale) {
if (!isStale?.()) {
cache.set(cacheKey, promise);
}
}
Expand Down
Loading