Merged
Conversation
Member
Author
|
The current unit test coverage is a bit over 75%. Need to improve that to at least 80% |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #151 +/- ##
===========================================
+ Coverage 73.14% 80.10% +6.95%
===========================================
Files 48 48
Lines 4092 4091 -1
Branches 715 715
===========================================
+ Hits 2993 3277 +284
+ Misses 896 630 -266
+ Partials 203 184 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
It's 79.71% 💀 |
Member
henrikjacobsenfys
left a comment
There was a problem hiding this comment.
I'm not too familiar with the interface factory and global object, but it looks good to me. I have only two minor comments/questions.
Contributor
|
Shouldn't this PR go into develop? Why is it going into Master? |
Member
Author
because I'm a blind numpty. Fixed. |
Closed
Member
Author
|
80.23%. There we go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class had ZERO unit test coverage. Now we have it covered.
Also, added codecov.
For this branch, check out
https://app.codecov.io/gh/EasyScience/corelib/tree/interface_factory_unit_tests