Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (4)
📝 WalkthroughWalkthroughUpdated Hive client defaults (longer timeout, higher failover threshold), added try/catch around a posts API call to log errors and return null on failure, and bumped package versions + changelog entries for sdk and wallets. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/sdk/src/modules/posts/queries/get-waves-by-host-query-options.ts`:
- Around line 42-52: The RPC catch block in get-waves-by-host-query-options.ts
that calls CONFIG.hiveClient.call("bridge","get_account_posts", rpcParams)
should not return null (which makes queryFn return an empty array and hides
transient failures); instead rethrow or propagate the error so upstream
retry/error handling runs. Replace the current catch that logs and returns null
with logic that logs the error and then throw err (or return
Promise.reject(err)) from the same scope (the container retrieval for variable
containers) so that get_account_posts failures surface to queryFn and trigger
retries.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/sdk/src/modules/core/config.tspackages/sdk/src/modules/posts/queries/get-waves-by-host-query-options.ts
Comment on lines
+42
to
+52
| let containers: WaveEntry[]; | ||
| try { | ||
| containers = (await CONFIG.hiveClient.call( | ||
| "bridge", | ||
| "get_account_posts", | ||
| rpcParams | ||
| )) as WaveEntry[]; | ||
| } catch (err) { | ||
| console.error("[SDK] getThreads get_account_posts error:", err); | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
Don’t convert RPC failures into a successful empty result.
At Line 51, returning null causes queryFn (Line 115) to return [], so transient RPC failures look like “no waves” and skip normal error/retry handling.
💡 Suggested fix
} catch (err) {
console.error("[SDK] getThreads get_account_posts error:", err);
- return null;
+ throw err instanceof Error ? err : new Error("get_account_posts failed");
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| let containers: WaveEntry[]; | |
| try { | |
| containers = (await CONFIG.hiveClient.call( | |
| "bridge", | |
| "get_account_posts", | |
| rpcParams | |
| )) as WaveEntry[]; | |
| } catch (err) { | |
| console.error("[SDK] getThreads get_account_posts error:", err); | |
| return null; | |
| } | |
| let containers: WaveEntry[]; | |
| try { | |
| containers = (await CONFIG.hiveClient.call( | |
| "bridge", | |
| "get_account_posts", | |
| rpcParams | |
| )) as WaveEntry[]; | |
| } catch (err) { | |
| console.error("[SDK] getThreads get_account_posts error:", err); | |
| throw err instanceof Error ? err : new Error("get_account_posts failed"); | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/sdk/src/modules/posts/queries/get-waves-by-host-query-options.ts`
around lines 42 - 52, The RPC catch block in get-waves-by-host-query-options.ts
that calls CONFIG.hiveClient.call("bridge","get_account_posts", rpcParams)
should not return null (which makes queryFn return an empty array and hides
transient failures); instead rethrow or propagate the error so upstream
retry/error handling runs. Replace the current catch that logs and returns null
with logic that logs the error and then throw err (or return
Promise.reject(err)) from the same scope (the container retrieval for variable
containers) so that get_account_posts failures surface to queryFn and trigger
retries.
feruzm
added
the
patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #682
Summary by CodeRabbit
Bug Fixes
Chores