Skip to content

Conversation

@dmatej
Copy link
Contributor

@dmatej dmatej commented Oct 28, 2025

Test

  • Can use embedded OR server as an alternative
  • Parameters were extracted to own class, makes experiments easy
  • create+list separated
  • Using ShrinkWrap instead of the dependency plugin to resolve dependencies makes possible also running the test in IDE.

ConnectionPool

  • extracted methods made code safer to NPEs
  • System.Logger
  • fixed several issues with wait-notify; could also time out

- Is able to reproduce several types of errors

Signed-off-by: David Matějček <[email protected]>
- There is a path where embedded uses this method too, then thrown NPE

Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- code cleanup to reduce risk of NPEs reproducible by the performance test

Signed-off-by: David Matějček <[email protected]>
@dmatej
Copy link
Contributor Author

dmatej commented Oct 28, 2025

#25752 is related a bit - with that I could enable the monitoring for embedded too :-)

@dmatej dmatej marked this pull request as ready for review October 29, 2025 13:28
@dmatej dmatej added this to the 7.1.0 milestone Oct 29, 2025
- Attempt to fix incompatible JNA on Eclipse's Jenkins

Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej force-pushed the jdbc branch 3 times, most recently from d47daf1 to a871a1a Compare October 31, 2025 09:42
- The Jenkins is slower than usual these days

Signed-off-by: David Matějček <[email protected]>
- The embedded maven plugin sets the trustStore which might affect Maven's
  behavior when it tries to download dependencies after this part.
- It should not be a problem for the TCK as it is never executed in the same
  reactor (would run weeks if it would even succeed as it doesn't do proper
  cleanup too)
- We should target this later. Also JPMS in embedded.

This reverts commit 3d19d9a.

Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej requested a review from a team October 31, 2025 15:08
@arjantijms arjantijms merged commit 263bb5e into eclipse-ee4j:master Oct 31, 2025
6 checks passed
@dmatej dmatej deleted the jdbc branch October 31, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants