Skip to content

Conversation

Mc-Hoyos
Copy link

@Mc-Hoyos Mc-Hoyos commented Oct 17, 2025

What it does

Adds the hGrab and vGrab options to the GLayoutOptions class.

Fixes eclipse-glsp/glsp/issues/1592

How to test

When creating layout options the 'vGrab' and 'hGrab' methods are accesible.

Follow-ups

I could not find where the options are used to send them to the server, so that might need revision too.

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@tortmayr tortmayr self-requested a review October 18, 2025 15:23
@tortmayr
Copy link
Contributor

tortmayr commented Oct 19, 2025

Changes look good to me.
Since GLSP is a member of the Eclipse Foundation, all contributors must first sign the Eclipse Contributor Agreement (ECA) before their code changes can be merged into source. The Eclipse Foundation maintains an ECA FAQ with more information about the ECA’s provisions.

Please sign the ECA, so that we can accept your PR.

Sidenote: Since the issue is tracked in other repository you have to use the full reference in the Fixes message:
Fixes #1592 -> Fixes eclipse-glsp/glsp/issues/1592
(I updated the PR description accordingly)

@Mc-Hoyos
Copy link
Author

Mc-Hoyos commented Oct 20, 2025

I am a Eclipse contributor, but under a different email. Should I open another PR with commits from that user?

https://www.eclipse.org/user/hhoyos

@tortmayr
Copy link
Contributor

Yes, that sounds like a good solution. I don't think that there is another way to pass the ECA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GLayoutOptions does not have hGrab and vGrap options

2 participants