-
Notifications
You must be signed in to change notification settings - Fork 102
Enable compiler's sanitizers [thread,ub, and address] #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable compiler's sanitizers [thread,ub, and address] #1155
Conversation
Signed-off-by: Ziad Mostafa <[email protected]>
Signed-off-by: Ziad Mostafa <[email protected]>
32c5fd7 to
777bd78
Compare
Signed-off-by: Ziad Mostafa <[email protected]>
Signed-off-by: Ziad Mostafa <[email protected]>
777bd78 to
f404393
Compare
Signed-off-by: Ziad Mostafa <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
+ Coverage 77.90% 77.92% +0.02%
==========================================
Files 360 360
Lines 38788 38788
Branches 807 807
==========================================
+ Hits 30217 30225 +8
+ Misses 7932 7924 -8
Partials 639 639
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: Ziad Mostafa <[email protected]>
a935791 to
6aba344
Compare
Signed-off-by: Ziad Mostafa <[email protected]>
Signed-off-by: Ziad Mostafa <[email protected]>
72009f0 to
129898c
Compare
Signed-off-by: Ziad Mostafa <[email protected]>
94f1b81 to
05b2cc8
Compare
Signed-off-by: Ziad Mostafa <[email protected]>
79fa05f to
8993861
Compare
Signed-off-by: Ziad Mostafa <[email protected]>
8993861 to
c65e7c9
Compare
Signed-off-by: Ziad Mostafa <[email protected]>
Signed-off-by: Ziad Mostafa <[email protected]>
Signed-off-by: Ziad Mostafa <[email protected]>
| set(ICEORYX2_TEST_CXX_FLAGS ${ICEORYX2_TEST_CXX_FLAGS} ${ICEORYX2_SANITIZER_FLAGS} CACHE INTERNAL "") | ||
|
|
||
| # Sanitizer flags must also be added to linker flags | ||
| set(ICEORYX2_LINK_FLAGS ${ICEORYX2_LINK_FLAGS} ${ICEORYX2_SANITIZER_FLAGS} CACHE INTERNAL "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: this can be removed, after fixing the typo the linker already includes sanitizer flags
Signed-off-by: Ziad Mostafa <[email protected]>
Signed-off-by: Ziad Mostafa <[email protected]>
Signed-off-by: Ziad Mostafa <[email protected]>
|
@elBoberido would be nice to get your feedback about this PR and the test failure I am getting while running the tests with sanitizers, also I had issues with macos too. I tried to match sanitizers in iceoryx as much as I can and not sure what might be wrong or still missing. |
Notes for Reviewer
Pre-Review Checklist for the PR Author
Convert to draft)SPDX-License-Identifier: Apache-2.0 OR MITiox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #957