Skip to content

Conversation

@dkroenke
Copy link
Member

Notes for Reviewer

For better CI performance the following work is done:

  • separate execution logic from trigger scripts into own workflow files
  • create a nightly CI job that contains the most of the "unstable" jobs and jobs with build_mode=release to unload the Pull-Request Pipeline
  • add caching via sccache for most of the platforms, Windows doesn't work at the moment
  • Reactivate Cirrus CI for FreeBSD jobs
  • Fix bug in Socket Handling on Windows to make use of the windows-latest runners in GitHub (Windows 2025)

This is just a first step towards better handling in CI and the arrangement with the jobs is up to discussions. Comments are welcome!

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates #3
Closes #347
Closes #1049

@dkroenke dkroenke self-assigned this Nov 13, 2025

on:
schedule:
- cron: "0 6 * * 1-5"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We schedule now on 6 AM every workday (excluding weekends), we could maybe schedule more often and earlier.

@dkroenke
Copy link
Member Author

Open Points to be addressed:

  • Nightly run fails need to be informed to the repository maintainers
  • Further optimize the PR Pipeline
  • Move build logic from Yaml files into scripts that are only called from the CI

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.86%. Comparing base (78ec617) to head (f0a7f5a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
+ Coverage   77.83%   77.86%   +0.03%     
==========================================
  Files         360      360              
  Lines       38833    38835       +2     
  Branches      816      817       +1     
==========================================
+ Hits        30225    30239      +14     
+ Misses       7961     7948      -13     
- Partials      647      648       +1     
Flag Coverage Δ
CPP 65.73% <ø> (-0.03%) ⬇️
Rust 77.82% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +44 to +48
- name: Run code examples in documentation
run: cargo test --workspace --doc ${{ inputs.cargo-features-flag }}

- name: Build documentation
run: cargo doc ${{ inputs.cargo-features-flag }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can potentially move these steps into an own documentation job (running only on Ubuntu) to optimize the overall timing of the PR-Pipeline. Both jobs take up to 10 mins each and are blocking the rest of the Pipeline.
It make more sense to have here fast checks that fail early. Everything that takes longer needs to be executed later.

@elfenpiff elfenpiff mentioned this pull request Nov 21, 2025
13 tasks
@dkroenke dkroenke force-pushed the iox2-3-add-nightly-run-in-ci branch 2 times, most recently from 09c8210 to 4fcb34f Compare November 21, 2025 15:48
@dkroenke dkroenke force-pushed the iox2-3-add-nightly-run-in-ci branch 7 times, most recently from a30f8b3 to 30ea61a Compare November 27, 2025 11:16
@dkroenke dkroenke force-pushed the iox2-3-add-nightly-run-in-ci branch from 30ea61a to f0a7f5a Compare November 27, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Builds failing on Windows 2025 Fully enable FreeBSD CI

1 participant