-
Notifications
You must be signed in to change notification settings - Fork 101
[#3] Restructure GitHub CI jobs #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[#3] Restructure GitHub CI jobs #1183
Conversation
|
|
||
| on: | ||
| schedule: | ||
| - cron: "0 6 * * 1-5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We schedule now on 6 AM every workday (excluding weekends), we could maybe schedule more often and earlier.
|
Open Points to be addressed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
+ Coverage 77.83% 77.86% +0.03%
==========================================
Files 360 360
Lines 38833 38835 +2
Branches 816 817 +1
==========================================
+ Hits 30225 30239 +14
+ Misses 7961 7948 -13
- Partials 647 648 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| - name: Run code examples in documentation | ||
| run: cargo test --workspace --doc ${{ inputs.cargo-features-flag }} | ||
|
|
||
| - name: Build documentation | ||
| run: cargo doc ${{ inputs.cargo-features-flag }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can potentially move these steps into an own documentation job (running only on Ubuntu) to optimize the overall timing of the PR-Pipeline. Both jobs take up to 10 mins each and are blocking the rest of the Pipeline.
It make more sense to have here fast checks that fail early. Everything that takes longer needs to be executed later.
09c8210 to
4fcb34f
Compare
a30f8b3 to
30ea61a
Compare
30ea61a to
f0a7f5a
Compare
Notes for Reviewer
For better CI performance the following work is done:
sccachefor most of the platforms, Windows doesn't work at the momentwindows-latestrunners in GitHub (Windows 2025)This is just a first step towards better handling in CI and the arrangement with the jobs is up to discussions. Comments are welcome!
Pre-Review Checklist for the PR Author
Convert to draft)SPDX-License-Identifier: Apache-2.0 OR MITiox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)task-list-completed)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates #3
Closes #347
Closes #1049