Make sendResponsePending a free function #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-schilling
requested review from
Copilot,
matthiaskessler and
rolandreichweinbmw
Copilot finished reviewing on behalf of
christian-schilling
November 21, 2025 14:19
There was a problem hiding this comment.
Pull request overview
This PR refactors the sendResponsePending functionality from a member function to a free function, improving testability and reducing coupling between components.
- Extracted response pending logic into two free functions:
buildResponsePendingTransportMessageandsendResponsePending - Updated three call sites to use the new free functions
- Removed
_pendingMessageinitialization from constructor since the message is now built on demand
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| libs/bsw/uds/src/uds/connection/IncomingDiagConnection.cpp | Added two new free functions (buildResponsePendingTransportMessage and sendResponsePending), removed the old member function implementation, and updated three call sites to use the new pattern |
| libs/bsw/uds/include/uds/connection/IncomingDiagConnection.h | Removed member function declaration and removed _pendingMessage initialization from constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
christian-schilling
force-pushed
the
@changes/main/[email protected]/free-pending
branch
from
a376442 to
dd4a4a7
Compare
rolandreichweinbmw
approved these changes
Nov 25, 2025
rolandreichweinbmw
merged commit efe2613
into
eclipse-openbsw:main
136 of 264 checks passed
christian-schilling
deleted the
@changes/main/[email protected]/free-pending
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.