Fix flaky testItemOrder in ProgressViewTests #3496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
@HeikoKlare any concern? I think this makes sense |
vogella
force-pushed
the
fix-flaky-progress-view-test
branch
3 times, most recently
from
39af270 to
c668b83
Compare
The test was failing randomly due to a race condition with the ProgressViewerComparator's stable sorting mechanism (lastIndexes). Root cause: - The comparator maintains a HashMap of previous positions to provide visual stability (preventing jobs from jumping around in the UI) - During test execution, throttled updates would occur while jobs were being scheduled, causing some jobs to be added to lastIndexes before others - This resulted in an inconsistent baseline where jobs were sorted by schedule order rather than priority order Fix: - Reopen the progress view after all jobs are scheduled and running to reset the comparator's lastIndexes state - This ensures all jobs are sorted by priority from a clean state, eliminating the race condition - Removed the unreliable timing-based approach that tried to manipulate throttled updates The test now passes reliably by working with the stable sorting behavior rather than against it. Fixes eclipse-platform#195 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
vogella
force-pushed
the
fix-flaky-progress-view-test
branch
from
c668b83 to
4da373c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ProgressViewTests.testItemOrderto fail randomlyProgressViewerComparator's stable sorting mechanismRoot Cause
The test was failing due to a race condition with the
ProgressViewerComparator'slastIndexesHashMap:lastIndexesin schedule orderSolution
lastIndexesstateTesting
Test Plan
ProgressViewTests.testItemOrdermultiple times - all passFixes #195
🤖 Generated with Claude Code