Skip to content

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Nov 4, 2025

No description provided.

@vogella vogella marked this pull request as draft November 4, 2025 19:17
@vogella vogella force-pushed the claude/migrate-junit5-navigator-011CUoN5e3tNLn1omqjXa3JE branch from 7f85c3b to 9ae2db3 Compare November 4, 2025 19:19
This commit migrates all test classes in the
org.eclipse.ui.tests.navigator
bundle from JUnit 4 to JUnit 5. The migration includes:

Test Migration (31 files):
- Migrated NavigatorTestBase base class to JUnit 5 annotations
- Migrated 30 test classes using JUnit 5 APIs and annotations
- Replaced @before with @beforeeach
- Replaced @after with @AfterEach
- Replaced Assert.* with Assertions.*
- Updated all imports from org.junit.* to org.junit.jupiter.api.*

JUnit 4 Rules to JUnit 5 Extensions:
- Created new CloseTestWindowsExtension for proper window/shell cleanup
- Converted GoBackForwardsTest to use @RegisterExtension
- Converted FoldersAsProjectsContributionTest to use @tempdir
- Removed unnecessary TestRunLogUtil.LOG_TESTRUN rule from
PipelineChainTest

Files changed:
- 30 test files migrated to JUnit 5
- 1 base class (NavigatorTestBase) migrated to JUnit 5
- 1 new extension class (CloseTestWindowsExtension) created

All test imports now use org.junit.jupiter.api.* instead of org.junit.*
@vogella vogella force-pushed the claude/migrate-junit5-navigator-011CUoN5e3tNLn1omqjXa3JE branch from 9ae2db3 to d36f069 Compare November 4, 2025 19:19
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Test Results

 1 956 files   - 1 062   1 956 suites   - 1 062   1h 17m 25s ⏱️ - 1h 0m 41s
 8 102 tests  -   132   7 855 ✅  -   130  247 💤  -   2  0 ❌ ±0 
15 484 runs   - 8 138  14 989 ✅  - 7 839  495 💤  - 299  0 ❌ ±0 

Results for commit d36f069. ± Comparison against base commit 9c171a0.

This pull request removes 132 tests.
NavigatorTestSuite ActionProviderTest ‑ testAppearsBefore
NavigatorTestSuite ActionProviderTest ‑ testBasicModel
NavigatorTestSuite ActionProviderTest ‑ testOverride
NavigatorTestSuite ActivityTest ‑ testCategoryWizard
NavigatorTestSuite ActivityTest ‑ testProviderFilter
NavigatorTestSuite CdtTest ‑ testCdt1
NavigatorTestSuite EvaluationCacheTest ‑ testNotSameInstEqualNotOverrides
NavigatorTestSuite EvaluationCacheTest ‑ testNotSameInstEqualOverrides
NavigatorTestSuite EvaluationCacheTest ‑ testOnVisibilityOrActivationChangeClearsCaches
NavigatorTestSuite EvaluationCacheTest ‑ testReplaceNotOverrides
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant