-
Notifications
You must be signed in to change notification settings - Fork 12
Improvement: Quality Management, ML2 #65 #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The created documentation from the pull request is available at: docu-html |
| | The conformance of the feature contribution is checked. | ||
| | The conformance of the feature contribution is checked. The conformance check consists of | ||
| | * No open issues that are related to quality that are relevant for the feature contribution | ||
| | * All required work products are provided and fulfill the quality criteria as defined in the quality management plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not add link here to the quality management plan, wp_definition? And change the definition like in safety to the Platform Management Plan to make it visible, that it is a platform wide plan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it
| * Execute Work Product Reviews | ||
| * Consult and execute Quality Trainings | ||
| * Monitoring/improving of Quality activities | ||
| * Creating/maintain Quality Management Plan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does these changes mean? It looks like 2 indents instead one only in the generated documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't correct rendered so I had to add in every line a additional tab. This looks a little bit strange in the diff.
|
|
||
| * - Review Id | ||
| - Link to checklist | ||
| * - SafMP_00_01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id is copy&paste from Safety, replace e.g. to SecMP_00_01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it
| - Remarks | ||
| - Issue link | ||
| * - CMP_00_01 | ||
| - Are the objectives and scope defined? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not add remarks here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added remarks
|
|
||
| Quality Management plan review checklist template | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remarks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added remarks
|
|
||
| * - Review Id | ||
| - Link to checklist | ||
| * - SafMP_00_01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id is copy&paste from Safety
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it
| - :need:`gd_chklst__change_cr_review` | ||
|
|
||
|
|
||
| Release Management plan review checklist template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed headline
| - Remarks | ||
| - Issue link | ||
| * - SWV_00_01 | ||
| - Are the objectives and scope defined? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remarks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added remarks
|
|
||
| * - Review Id | ||
| - Link to checklist | ||
| * - SafMP_00_01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id is copy&paste from Safety
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it
| - passed [yes | no] | ||
| - Remarks | ||
| - Issue link | ||
| * - SWV_00_01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id is copy&paste from Verification, Remarks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it and and added remarks
| Change Management plan review checklist template | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| .. list-table:: Release Management plan review checklist template |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release, Header is Change Management?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it
| - passed [yes | no] | ||
| - Remarks | ||
| - Issue link | ||
| * - CMP_00_01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still same as Change Management Plan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kept it because I changed the ID of Change Management Plan
|
|
||
| * - Review Id | ||
| - Link to checklist | ||
| * - CMP_00_01 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still same as Configuration Management Plan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it
26abaf5 to
544e55e
Compare
process/process_areas/quality_management/guidance/quality_report_template.rst
Show resolved
Hide resolved
process/process_areas/quality_management/guidance/quality_report_template.rst
Outdated
Show resolved
Hide resolved
process/process_areas/quality_management/guidance/quality_report_template.rst
Outdated
Show resolved
Hide resolved
masc2023
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My findings are resolved
process/process_areas/quality_management/guidance/quality_report_template.rst
Outdated
Show resolved
Hide resolved
process/process_areas/quality_management/guidance/quality_report_template.rst
Outdated
Show resolved
Hide resolved
process/process_areas/quality_management/guidance/quality_plan_guideline.rst
Show resolved
Hide resolved
|
@pahmann , fine for you now, then I could take it for the next release, thank you |
pahmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the current version of the Quality Management updates. I will address further improvements as respective tickets separately.
Closes several improvements from #65