-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[vscode] API evolution (public and proposed) to 1.104.0 #16281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good to me, thanks for this PR, Nina!
Only a minor comment on the theia.d.ts comments and annotations. Could you please push an additional commit with this requested change?
I could test the extensions 1.104, all seems to behave fine except the typescript one. But I suspect this is either a misconfiguration on my side or an issue on how the extension works currently (tsserver was deleted by a third party app like antivirus...)
Resolves GH-16257 Contributed on behalf of STMicroelectronics
Hi @rschnekenbu, thanks for your review and clarifications, much appreciated! Regarding the TypeScript extension, I'll have another look to see if I perhaps overlooked that issue on my end. |
Part of GH-16134 Contributed on behalf of STMicroelectronics
Resolves GH-16258 Contributed on behalf of STMicroelectronics
Resolves GH-16259 Contributed on behalf of STMicroelectronics
Resolves GH-16260 Contributed on behalf of STMicroelectronics
Resolves GH-16161 Contributed on behalf of STMicroelectronics
Resolves GH-16261 Contributed on behalf of STMicroelectronics
Resolves GH-16278 Contributed on behalf of STMicroelectronics
Resolves GH-16135 Contributed on behalf of STMicroelectronics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The report looks good now, and I could test the extensions with the mode:production on, and the typescript extension is working like a charm. When removing the mode:production from the options, the typescript extension fails. But that is unrelated to the 1.104 API updates.
What it does
[vscode] add (Extension)TerminalOptions shellIntegrationNonce property
Resolves GH-16257
[vscode] update type LanguageModelInputPart
Resolves GH-16258
[vscode] chore: several minor documentation updates in theia.d.ts
Part of GH-16134
[vscode] add a new set of interfaces related to language models
Resolves GH-16259
[vscode] add a new function to the lm namespace
Resolves GH-16260
[vscode] implement proposed.scmProviderOptions API
Resolves GH-16161
[vscode] extend stubbed TerminalCompletionItemKind proposed API
Resolves GH-16261
[vscode] implement proposed.textEditorDiffInformation API
Resolves GH-16278
[vscode] bump API compatibility to 1.104.0
Resolves GH-16135
How to test
Follow-ups
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers