Skip to content

Conversation

ndoschek
Copy link
Contributor

@ndoschek ndoschek commented Sep 12, 2025

What it does

[vscode] add (Extension)TerminalOptions shellIntegrationNonce property
Resolves GH-16257
[vscode] update type LanguageModelInputPart
Resolves GH-16258
[vscode] chore: several minor documentation updates in theia.d.ts
Part of GH-16134
[vscode] add a new set of interfaces related to language models
Resolves GH-16259
[vscode] add a new function to the lm namespace
Resolves GH-16260
[vscode] implement proposed.scmProviderOptions API
Resolves GH-16161
[vscode] extend stubbed TerminalCompletionItemKind proposed API
Resolves GH-16261
[vscode] implement proposed.textEditorDiffInformation API
Resolves GH-16278
[vscode] bump API compatibility to 1.104.0
Resolves GH-16135

How to test

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Contributed on behalf of STMicroelectronics

Review checklist

Reminder for reviewers

Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good to me, thanks for this PR, Nina!
Only a minor comment on the theia.d.ts comments and annotations. Could you please push an additional commit with this requested change?
I could test the extensions 1.104, all seems to behave fine except the typescript one. But I suspect this is either a misconfiguration on my side or an issue on how the extension works currently (tsserver was deleted by a third party app like antivirus...)

Resolves GH-16257

Contributed on behalf of STMicroelectronics
@ndoschek
Copy link
Contributor Author

Hi @rschnekenbu, thanks for your review and clarifications, much appreciated!
I updated the respective commit and also added the stubbed annotations to the theia.d.ts file (see 58aeb80)

Regarding the TypeScript extension, I'll have another look to see if I perhaps overlooked that issue on my end.

Part of GH-16134

Contributed on behalf of STMicroelectronics
Resolves GH-16258

Contributed on behalf of STMicroelectronics
Resolves GH-16259

Contributed on behalf of STMicroelectronics
Resolves GH-16260

Contributed on behalf of STMicroelectronics
Resolves GH-16161

Contributed on behalf of STMicroelectronics
Resolves GH-16261

Contributed on behalf of STMicroelectronics
Resolves GH-16278

Contributed on behalf of STMicroelectronics
Resolves GH-16135

Contributed on behalf of STMicroelectronics
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
The report looks good now, and I could test the extensions with the mode:production on, and the typescript extension is working like a charm. When removing the mode:production from the options, the typescript extension fails. But that is unrelated to the 1.104 API updates.

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Sep 23, 2025
@ndoschek ndoschek merged commit b9912f0 into master Sep 24, 2025
22 of 25 checks passed
@ndoschek ndoschek deleted the GH-16134 branch September 24, 2025 07:12
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Sep 24, 2025
@github-actions github-actions bot added this to the 1.65.0 milestone Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment