Skip to content

refactor: activate rule no-unused-private-class-members #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: activate rule no-unused-private-class-members #1434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export default defineConfig([

"no-use-before-define": "error",

"no-unused-private-class-members": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
"no-unused-private-class-members": "error",
"no-prototype-builtins": "off",
"no-case-declarations": "off",

Expand Down
6 changes: 6 additions & 0 deletions packages/core/src/consumed-thing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ export interface ClientAndForm {
}

class ConsumedThingProperty extends ThingProperty implements ThingProperty, BaseSchema {
// eslint-disable-next-line no-unused-private-class-members
#name: string;
// eslint-disable-next-line no-unused-private-class-members
#thing: ConsumedThing;

constructor(name: string, thing: ConsumedThing) {
Expand All @@ -77,7 +79,9 @@ class ConsumedThingProperty extends ThingProperty implements ThingProperty, Base
}

class ConsumedThingAction extends ThingAction implements ThingAction {
// eslint-disable-next-line no-unused-private-class-members
#name: string;
// eslint-disable-next-line no-unused-private-class-members
#thing: ConsumedThing;

constructor(name: string, thing: ConsumedThing) {
Expand All @@ -89,7 +93,9 @@ class ConsumedThingAction extends ThingAction implements ThingAction {
}

class ConsumedThingEvent extends ThingEvent {
// eslint-disable-next-line no-unused-private-class-members
#name: string;
// eslint-disable-next-line no-unused-private-class-members
#thing: ConsumedThing;

constructor(name: string, thing: ConsumedThing) {
Expand Down