Closed
Conversation
…changes' into merge_of_rileys_code_and_latest_changes
Contributor
Author
|
Out of date. Making new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the BACnet Protocol Proxy library, focusing on documentation, dependency management, and error handling. The most significant changes are an expanded and reformatted
README.md, the addition of a development dependencies section inpyproject.toml, and improved error handling in the BACnet protocol implementation.Documentation improvements:
README.mdto include project badges, installation instructions, dependency information, development guidelines, and a disclaimer notice for clarity and professionalism.Dependency management:
[tool.poetry.group.dev.dependencies]section inpyproject.tomlto clarify that there are currently no additional development dependencies.Error handling:
write_propertymethod inbacnet.pyto return the exception object instead of printing it, improving error reporting and testability.