Skip to content

Enforce the use of utf-8 as default charset for api mappings #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
netomi wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Enforce the use of utf-8 as default charset for api mappings #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions server/src/main/java/org/eclipse/openvsx/RegistryApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler;
import org.springframework.security.web.firewall.HttpStatusRequestRejectedHandler;
import org.springframework.security.web.firewall.RequestRejectedHandler;
import org.springframework.web.filter.CharacterEncodingFilter;

@SpringBootApplication
@EnableScheduling
Expand Down Expand Up @@ -62,6 +63,23 @@ public FilterRegistrationBean<ShallowEtagHeaderFilter> shallowEtagHeaderFilter()
return registrationBean;
}

@Bean
public FilterRegistrationBean<CharacterEncodingFilter> forceUTF8EncodingFilter() {
var registrationBean = new FilterRegistrationBean<CharacterEncodingFilter>();

// Enforce the use of utf-8 as character encoding for requests / responses as spring boot defaults to ISO-8859-1.
// This avoids the need to explicitly specify the charset in the returned Content-Type header for each mapping.
CharacterEncodingFilter filter = new CharacterEncodingFilter();
filter.setEncoding("UTF-8");
filter.setForceEncoding(true);

registrationBean.setFilter(filter);
registrationBean.addUrlPatterns("/api/*");
registrationBean.setOrder(Ordered.LOWEST_PRECEDENCE);

return registrationBean;
}

@Bean
public RequestRejectedHandler requestRejectedHandler() {
return new HttpStatusRequestRejectedHandler();
Expand Down