Change --omit-covered from 100% coverage to --fail-under value#119
Open
strobeflash wants to merge 2 commits intoeconchick:masterfrom
Open
Change --omit-covered from 100% coverage to --fail-under value#119strobeflash wants to merge 2 commits intoeconchick:masterfrom
strobeflash wants to merge 2 commits intoeconchick:masterfrom
Conversation
Owner
|
Sorry for the silence! I like this idea, but I want to keep the same behavior (not introduce a breaking change like this, even though it is innocuous), while allowing the option to hide files that meet the I think it'd be a better approach to have Feel free to update this PR; otherwise, I can add this at some point for the next release ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
Change --omit-covered from 100% coverage to --fail-under value
Motivation and Context
--omit-covered currently only hides 100% covered files even when --fail-under sets another value
Have you tested this? If so, how?
Ran interrogate with the changes and they seem to work.
Checklist for PR author(s)
No, but already before my changes.
tox -e docsorinterrogate -c pyproject.toml(I mean, we should set a good example 😄).README.rst.README.rstanddocs/index.rstfor any new/changed CLI flags.versionadded,versionchanged, ordeprecateddirectives. Find the appropriate next version in the project's__init__.pyfile.Release note