tests: add return type hints to tests#183
Open
mattcristal wants to merge 2 commits intoeconchick:masterfrom
Open
tests: add return type hints to tests#183mattcristal wants to merge 2 commits intoeconchick:masterfrom
mattcristal wants to merge 2 commits intoeconchick:masterfrom
Conversation
used the VS code extension
for more information, see https://pre-commit.ci
ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Description
I have added the return type hints to some test functions.
Motivation and Context
Taking advantage of type hints, this contributes to make the test functions more clear and readable.
Have you tested this? If so, how?
I have run, locally, on macOS:
All tests are passing. Overall, there is no change in behavior.
Checklist for PR author(s)
tox -e docsorinterrogate -c pyproject.toml(I mean, we should set a good example 😄).README.rst.README.rstanddocs/index.rstfor any new/changed CLI flags.versionadded,versionchanged, ordeprecateddirectives. Find the appropriate next version in the project's__init__.pyfile.Release note