Skip to content

tests: add return type hints to tests#183

Open
mattcristal wants to merge 2 commits intoeconchick:masterfrom
mattcristal:add-return-type-hints-to-tests
Open

tests: add return type hints to tests#183
mattcristal wants to merge 2 commits intoeconchick:masterfrom
mattcristal:add-return-type-hints-to-tests

Conversation

@mattcristal
Copy link
Copy Markdown

@mattcristal mattcristal commented Jul 4, 2024

Hey, I just made a Pull Request!

Description

I have added the return type hints to some test functions.

Motivation and Context

Taking advantage of type hints, this contributes to make the test functions more clear and readable.

Have you tested this? If so, how?

I have run, locally, on macOS:

python -m pytest

All tests are passing. Overall, there is no change in behavior.

Checklist for PR author(s)

  • Changes are covered by unit tests (no major decrease in code coverage %).
  • All tests pass.
  • Docstring coverage is 100% via tox -e docs or interrogate -c pyproject.toml (I mean, we should set a good example 😄).
  • Updates to documentation:
    • Document any relevant additions/changes in README.rst.
    • Manually update both the README.rst and docs/index.rst for any new/changed CLI flags.
    • Any changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in the project's __init__.py file.

Release note


@mattcristal mattcristal marked this pull request as ready for review July 4, 2024 07:00
Copy link
Copy Markdown

@sunil-thorat-cts sunil-thorat-cts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app

@sunil-thorat-cts
Copy link
Copy Markdown

app

ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants