The assurances of the voter can be obtained from a cast vote if canup… #313

valentinbujdoso · 2019-04-03T16:33:20Z

…date is true #242

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

src/main/java/org/rulez/demokracia/pdengine/SessionFactoryManager.java

src/test/java/org/rulez/demokracia/pdengine/UnimplementedTests.java

src/main/java/org/rulez/demokracia/pdengine/SessionFactoryManager.java

src/test/java/org/rulez/demokracia/pdengine/UnimplementedTests.java

valentinbujdoso · 2019-04-04T14:45:29Z

Im not clearly understand how can I "fake" it. could you explaint it a little bite detailed?

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

magwas · 2019-04-04T14:53:54Z

Im not clearly understand how can I "fake" it. could you explaint it a little bite detailed?

https://blog.pragmatists.com/test-doubles-fakes-mocks-and-stubs-1a7491dfa3da

src/test/java/org/rulez/demokracia/pdengine/UnimplementedTests.java

src/main/java/org/rulez/demokracia/pdengine/FakeADAAssuranceProvider.java

src/main/java/org/rulez/demokracia/pdengine/SessionFactoryManager.java

src/test/java/org/rulez/demokracia/pdengine/UnimplementedTests.java

valentinbujdoso · 2019-04-07T18:56:55Z

So something like this?

magwas

see poc/assurancemanager branch in my repo to understand how dependency injection (old school) works.
Build on that code.

src/main/java/org/rulez/demokracia/pdengine/FakeADAAssuranceProvider.java

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

magwas · 2019-04-09T13:27:04Z

Please provide full code coverage. Yes, even for the code I helped you with.

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

magwas · 2019-04-11T09:02:04Z

only an unimplemented test is needed for ADAAssuranceManager.getAssurances()

szirbucz · 2019-04-11T19:30:14Z

src/main/java/org/rulez/demokracia/pdengine/IVoteManager.java

+	List<String> getAssurances();
+
+	static AssuranceManager getAssuranceManager() {
+		return new ADAAssuranceManager();


Test it to kill zombie.

src/main/java/org/rulez/demokracia/pdengine/Voteable.java

valentinbujdoso · 2019-04-12T06:03:56Z

I will take a look tomorrow

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

valentinbujdoso · 2019-04-14T18:19:11Z

@magwas I created the test but it give back quite strange errors

magwas · 2019-04-16T04:39:23Z

you have received a pull request yesterday with the resolution of the conflicts.

…_can_be_obtained_from_a_cast_vote_if_canupdateis_true_242_java10_merge merge with current edemo/develop

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

valentinbujdoso · 2019-04-16T14:01:30Z

The import javax.xml.ws.WebServiceContext; cannot be resolved.
What should I do?

magwas · 2019-04-17T04:49:16Z

seems like jax-ws is missing. window/install new software.
Is it with the eclipse in the docker image or your own setup?

magwas · 2019-06-04T13:13:46Z

its going in in #333 @valentinbujdoso is it paid yet for you?

valentinbujdoso · 2019-06-09T19:30:28Z

@magwas:
Elnezest, hogy el vagyok veszve, a majusom nagyon suru volt, es a juniusom meg talan meg surubb lesz, de utana jelentkezem munkara keszen.
Ezt meg nem rendeztuk, ha visszatertem az elok korebe beszelunk rola.

valentinbujdoso added 3 commits April 3, 2019 18:32

The assurances of the voter can be obtained from a cast vote if canup…

3d5cac1

…date is true #242

fix

5d730c0

Merge branch 'develop' into feature/the_assurances_of_the_voter_can_b…

b6baf61

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

valentinbujdoso commented Apr 3, 2019

View reviewed changes

src/main/java/org/rulez/demokracia/pdengine/SessionFactoryManager.java Outdated Show resolved Hide resolved

valentinbujdoso commented Apr 3, 2019

View reviewed changes

src/test/java/org/rulez/demokracia/pdengine/UnimplementedTests.java Outdated Show resolved Hide resolved

magwas suggested changes Apr 4, 2019

View reviewed changes

valentinbujdoso added 2 commits April 4, 2019 16:45

Merge branch 'develop' into feature/the_assurances_of_the_voter_can_b…

d96504d

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

Fix tests

c911c65

magwas reviewed Apr 4, 2019

View reviewed changes

src/test/java/org/rulez/demokracia/pdengine/UnimplementedTests.java Outdated Show resolved Hide resolved

valentinbujdoso added 2 commits April 4, 2019 17:18

Fix

925ebec

Fix

8978c94

magwas suggested changes Apr 5, 2019

View reviewed changes

src/main/java/org/rulez/demokracia/pdengine/FakeADAAssuranceProvider.java Outdated Show resolved Hide resolved

src/main/java/org/rulez/demokracia/pdengine/SessionFactoryManager.java Outdated Show resolved Hide resolved

fix

3d5b349

magwas suggested changes Apr 6, 2019

View reviewed changes

src/main/java/org/rulez/demokracia/pdengine/SessionFactoryManager.java Outdated Show resolved Hide resolved

src/test/java/org/rulez/demokracia/pdengine/UnimplementedTests.java Outdated Show resolved Hide resolved

valentinbujdoso added 2 commits April 7, 2019 20:18

Fix

405fb07

Fix

731fcda

magwas suggested changes Apr 8, 2019

View reviewed changes

src/main/java/org/rulez/demokracia/pdengine/FakeADAAssuranceProvider.java Outdated Show resolved Hide resolved

valentinbujdoso added 4 commits April 8, 2019 22:14

Fix

c2da5df

Merge branch 'develop' into feature/the_assurances_of_the_voter_can_b…

7fc164a

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

Fix

906ed54

Kill mutant

73d6727

Merge branch 'develop' into feature/the_assurances_of_the_voter_can_b…

74e0916

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

szirbucz suggested changes Apr 11, 2019

View reviewed changes

Merge branch 'develop' into feature/the_assurances_of_the_voter_can_b…

3e3f4e7

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

Fix

cba82d9

Merge remote-tracking branch 'edemo/develop' into HEAD

fe8cf76

valentinbujdoso added 2 commits April 16, 2019 15:45

Merge pull request #2 from magwas/feature/the_assurances_of_the_voter…

95988a9

…_can_be_obtained_from_a_cast_vote_if_canupdateis_true_242_java10_merge merge with current edemo/develop

Merge branch 'develop' into feature/the_assurances_of_the_voter_can_b…

1ddcc03

…e_obtained_from_a_cast_vote_if_canupdateis_true_242

szirbucz mentioned this pull request Apr 29, 2019

Spring refactor of #242 #324

Closed

The assurances of the voter can be obtained from a cast vote if canup… #313

Are you sure you want to change the base?

The assurances of the voter can be obtained from a cast vote if canup… #313

Uh oh!

Conversation

valentinbujdoso commented Apr 3, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

valentinbujdoso commented Apr 4, 2019

Uh oh!

magwas commented Apr 4, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

valentinbujdoso commented Apr 7, 2019

Uh oh!

magwas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

magwas commented Apr 9, 2019

Uh oh!

magwas commented Apr 11, 2019

Uh oh!

szirbucz Apr 11, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

valentinbujdoso commented Apr 12, 2019

Uh oh!

valentinbujdoso commented Apr 14, 2019

Uh oh!

magwas commented Apr 16, 2019

Uh oh!

valentinbujdoso commented Apr 16, 2019

Uh oh!

magwas commented Apr 17, 2019

Uh oh!

magwas commented Jun 4, 2019

Uh oh!

valentinbujdoso commented Jun 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants