Add NixOS flake + install instructions for NixOS#64
Open
eth-p wants to merge 2 commits intoekaaty:develfrom
Open
Add NixOS flake + install instructions for NixOS#64eth-p wants to merge 2 commits intoekaaty:develfrom
eth-p wants to merge 2 commits intoekaaty:develfrom
Conversation
The `start-here-kde.svg` icon under `icons/src/places/scalable` does not exist, and it's used as the target for the `start-here-kde-plasma.svg` symlink. Remove it from `links.txt` so the built package does not contain any broken symlinks.
This allows users on NixOS to install the theme directly from a tagged release of the git repo.
Contributor
|
Please, submit this PR to the devel branch. Them main one is reserved only for releases. |
Author
|
My apologies. That's now fixed, and the PR is changed to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great work on the vinyl theme! I found it a few months ago, and I've been daily driving it since.
I use NixOS for my distro, and due to the way the package manager works on the system, I had to package it for nix before I could install it. It takes a bit of trial and error to do, and it's not as simple as the other available installation methods for vinyl. I felt it might help encourage other NixOS users to try the theme if it was easier to install, so I figured I would create this PR to help with that.
Ideally, I would have just added the package on the official NixOS nixpkgs repo, but their package guidelines suggest that vinyl-theme is just a little bit too niche right now to be accepted:
As a compromise, I added the package info (
flake.nix,package.nix) directly to the repo here, similar to how other projects like vicinae and kwin-effects-better-blur-dx do it.If you feel that it's too invasive to include the nix packaging within the vinyl-theme repo itself, no worries, just close this PR.