Skip to content

Conversation

trentm
Copy link
Member

@trentm trentm commented Jul 15, 2025

Recently I had to avoid using the ||= JS syntax to not break
dependency-check (used for 'npm run lint:deps'). That's lame.
4a77a0b

dependency-check is deprecated: https://www.npmjs.com/package/dependency-check
We could consider using knip. FWIW opentelemetry-js-contrib is using
it.

Here I've chosen to not install knip as a devDep, though we could
consider doing so. I avoided it because npm init @knip/config
installs TypeScript, which felt a bit overkill to me. We already
have TS at the top-level, so perhaps not bad to add it.

checklist

  • Discuss with David.
  • See about installing knip at the top-level.
  • Switch the other packages to knip as well.

Recently I had to avoid using the `||=` JS syntax to not break
dependency-check (used for 'npm run lint:deps'). That's lame.
4a77a0b

`dependency-check` is deprecated: https://www.npmjs.com/package/dependency-check
We could consider using `knip`. FWIW opentelemetry-js-contrib is using
it.

Here I've chosen to not install knip as a devDep, though we could
consider doing so. I avoided it because `npm init @knip/config`
**installs TypeScript**, which felt a bit overkill to me. We already
have TS at the top-level, so perhaps not bad to add it.
@trentm trentm self-assigned this Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant