chore: switch from dependency-check to knip for lint:deps #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently I had to avoid using the `||=` JS syntax to not break dependency-check (used for 'npm run lint:deps'). That's lame. 4a77a0b `dependency-check` is deprecated: https://www.npmjs.com/package/dependency-check We could consider using `knip`. FWIW opentelemetry-js-contrib is using it. Here I've chosen to not install knip as a devDep, though we could consider doing so. I avoided it because `npm init @knip/config` **installs TypeScript**, which felt a bit overkill to me. We already have TS at the top-level, so perhaps not bad to add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I had to avoid using the
||=JS syntax to not breakdependency-check (used for 'npm run lint:deps'). That's lame.
4a77a0b
dependency-checkis deprecated: https://www.npmjs.com/package/dependency-checkWe could consider using
knip. FWIW opentelemetry-js-contrib is usingit.
Here I've chosen to not install knip as a devDep, though we could
consider doing so. I avoided it because
npm init @knip/configinstalls TypeScript, which felt a bit overkill to me. We already
have TS at the top-level, so perhaps not bad to add it.
checklist