-
Notifications
You must be signed in to change notification settings - Fork 43
[beatsauthextension] Add support for kerberos #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| go 1.24.9 | ||
|
|
||
| require ( | ||
| github.com/elastic/beats/v7 v7.17.29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only import beats for Kerberos config creating/validation.
There is a PR up to move kerberos package to elastic-agent-libs so that we can do not have to import beats elastic/elastic-agent-libs#360. The CI failure is also related to the same
|
|
axw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khushijain21 code looks fine, just one small suggestion. Can you add some tests please?
|
|
||
| return client, nil | ||
| if beatAuthConfig.Kerberos.IsEnabled() { | ||
| return NewKerberosClientProvider(beatAuthConfig.Kerberos, client) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return NewKerberosClientProvider(beatAuthConfig.Kerberos, client) | |
| p, err := NewKerberosClientProvider(beatAuthConfig.Kerberos, client) | |
| if err != nil { | |
| return nil, fmt.Errorf("error creating Kerberos client provider: %w", err) | |
| } | |
| return p, nil |
Let's wrap the error, otherwise it will be difficult to understand the "invalid authentication type" error message.
|
Beatsauth extension has been moved into beats codebase. The related PR to support kerberos hence is also moved there |
This PR adds support for Kerberos authentication
Testing Steps:
logs-generic-default.