Skip to content

fix: Optional dep's path cannot find in newest npm #9274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2025
Merged

fix: Optional dep's path cannot find in newest npm #9274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d9f9bb
fix: Enhance dependency path validation in NodeModulesCollector
beyondkmp Sep 12, 2025
349cd5e
prettier
beyondkmp Sep 12, 2025
0730650
add changeset
beyondkmp Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/old-cherries-draw.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"app-builder-lib": patch
---

Optional dep's path cannot find in newest npm
8 changes: 8 additions & 0 deletions packages/app-builder-lib/src/node-module-collector/nodeModulesCollector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,14 @@ export abstract class NodeModulesCollector<T extends Dependency<T, OptionalsType
log.debug({ name: d.name, reference }, "cannot find path for dependency")
continue
}

// fix npm list issue
// https://github.com/npm/cli/issues/8535
if (!fs.existsSync(p)) {
log.debug({ name: d.name, reference, p }, "dependency path does not exist")
continue
}

const node: NodeModuleInfo = {
name: d.name,
version: reference,
Expand Down
Loading