Skip to content

chore: fix test-updater dockerized unit tests #9290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 29, 2025
Merged

chore: fix test-updater dockerized unit tests #9290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4d587a4
chore: fix unit tests by freezing tag of docker test images for updat…
mmaietta Sep 28, 2025
63be4a1
retry
mmaietta Sep 28, 2025
37f8a30
pnpm docker image
mmaietta Sep 28, 2025
73747d6
fix dockerfiles again
mmaietta Sep 28, 2025
f4ee356
retry
mmaietta Sep 28, 2025
54470ff
run as-is
mmaietta Sep 28, 2025
652b485
retry
mmaietta Sep 29, 2025
f761eed
try again
mmaietta Sep 29, 2025
398d618
retry
mmaietta Sep 29, 2025
63ef921
whoops
mmaietta Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions test/snapshots/updater/blackboxUpdateTest.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,72 @@ exports[`Electron autoupdate (fresh install & update) > linux > AppImage - arm64
}
`;

exports[`Electron autoupdate (fresh install & update) > linux > AppImage - x64 1`] = `
{
"linux": [
{
"arch": "x64",
"file": "TestApp.AppImage",
"updateInfo": {
"blockMapSize": "@blockMapSize",
"sha512": "@sha512",
"size": "@size",
},
},
{
"file": "latest-linux.yml",
"fileContent": {
"files": [
{
"blockMapSize": "@blockMapSize",
"sha512": "@sha512",
"size": "@size",
"url": "TestApp.AppImage",
},
],
"path": "TestApp.AppImage",
"releaseDate": "@releaseDate",
"sha512": "@sha512",
"version": "1.0.0",
},
},
],
}
`;

exports[`Electron autoupdate (fresh install & update) > linux > AppImage - x64 2`] = `
{
"linux": [
{
"arch": "x64",
"file": "TestApp.AppImage",
"updateInfo": {
"blockMapSize": "@blockMapSize",
"sha512": "@sha512",
"size": "@size",
},
},
{
"file": "latest-linux.yml",
"fileContent": {
"files": [
{
"blockMapSize": "@blockMapSize",
"sha512": "@sha512",
"size": "@size",
"url": "TestApp.AppImage",
},
],
"path": "TestApp.AppImage",
"releaseDate": "@releaseDate",
"sha512": "@sha512",
"version": "1.0.1",
},
},
],
}
`;

exports[`Electron autoupdate (fresh install & update) > linux > arch - (pacman) 1`] = `
{
"linux": [
Expand Down
1 change: 1 addition & 0 deletions test/src/helpers/launchAppCrossPlatform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ export function startXvfb(): { display: string; stop: () => void } {
})
})

console.log("Xvfb started on display", display)
return {
display,
stop,
Expand Down
35 changes: 31 additions & 4 deletions test/src/updater/Dockerfile-archlinux
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,41 @@
FROM archlinux:latest
FROM archlinux:base-20250629.0.373469

RUN pacman -Syu --noconfirm && \
pacman -S --noconfirm \
RUN pacman -Sy --noconfirm archlinux-keyring \
&& pacman -S --noconfirm gnupg \
&& pacman-key --init \
&& pacman-key --populate archlinux \
&& pacman-key --refresh-keys \
&& pacman -Syu --noconfirm \
&& pacman -S --noconfirm \
libxcrypt-compat \
base-devel \
git \
nodejs \
npm \
xorg-server-xvfb \
&& pacman -Scc --noconfirm
&& pacman -Scc --noconfirm \
&& rm -rf /var/lib/pacman/sync/* /var/cache/pacman/pkg/*

# install prerequisites for building
RUN pacman -Sy --noconfirm archlinux-keyring \
&& pacman -Syu --noconfirm \
&& pacman -S --noconfirm base-devel git sudo \
&& pacman -Scc --noconfirm \
&& rm -rf /var/lib/pacman/sync/* /var/cache/pacman/pkg/*

# create a non-root user for makepkg
RUN useradd -m builder && echo "builder ALL=(ALL) NOPASSWD: ALL" > /etc/sudoers.d/builder

USER builder
WORKDIR /home/builder

# build http-parser from AUR
RUN git clone https://aur.archlinux.org/http-parser.git \
&& cd http-parser \
&& makepkg -si --noconfirm

USER root
WORKDIR /project

RUN npm --silent install --global --depth 0 pnpm

Expand Down
17 changes: 10 additions & 7 deletions test/src/updater/Dockerfile-debian
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
FROM debian:bookworm-slim
FROM node:20-bookworm

RUN apt-get update && apt-get install -y curl gnupg xz-utils xvfb zypper binutils libasound2
# Install system + Electron runtime deps
RUN apt-get update \
&& apt-get install -y --no-install-recommends \
curl gnupg xz-utils xvfb zypper binutils \
libasound2 libgtk-3-0 libnotify4 libnss3 libxss1 libxtst6 \
xdg-utils libatspi2.0-0 libsecret-1-0 libgbm1 \
&& rm -rf /var/lib/apt/lists/*

RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash -
RUN apt-get install -y nodejs
RUN npm --silent install --global --depth 0 pnpm

RUN npm --silent install --global --depth 0 pnpm

WORKDIR /project
WORKDIR /project