Skip to content

Conversation

@lidel
Copy link
Contributor

@lidel lidel commented Oct 31, 2025

This PR:

  • updates WindowsAzureSigningConfiguration to accept publisherName as string | Array | null
  • aligns JSON schema to match TypeScript type definition
  • allows specifying multiple publisher names for certificate flexibility across certificate changes
  • no functional changes, implementation already handles arrays via asArray() helper and I've confirmed that in fix(windows): update publisher name ipfs/ipfs-desktop#3013 where we use this patch to fix our windows release

this change makes the schema match the existing documentation which states "Several names can be provided"

- update WindowsAzureSigningConfiguration to accept publisherName as string | Array<string> | null
- align JSON schema to match TypeScript type definition
- allows specifying multiple publisher names for certificate flexibility across certificate changes
- implementation already handles arrays via asArray() helper

this change makes the schema match the existing documentation which states "Several names can be provided"
@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

🦋 Changeset detected

Latest commit: 25477b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta
Copy link
Collaborator

mmaietta commented Nov 4, 2025

Looks like there's some compiler errors from the logs:

Error: packages/app-builder-lib/src/codeSign/windowsSignAzureManager.ts(99,5): error TS2322: Type 'Promise<string | string[] | null>' is not assignable to type 'Promise<string>'.
  Type 'string | string[] | null' is not assignable to type 'string'.
    Type 'null' is not assignable to type 'string'.
Error: packages/app-builder-lib/src/options/winOptions.ts(136,12): error TS2411: Property 'publisherName' of type 'string | string[] | null' is not assignable to 'string' index type 'string | Nullish'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants