Skip to content

fix: ensure control directory has right permissions #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
belloyang wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: ensure control directory has right permissions #261

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d792bad
fix: ensure control directory has right permissions
Aug 27, 2021
0d02201
correct spelling contrlDir -> controlDir.
Aug 27, 2021
64611fe
Merge branch 'main' into ensure-controll-dir-with-right-permissions
fcastilloec Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/installer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,13 @@ class DebianInstaller extends common.ElectronInstaller {
const dest = path.join(this.stagingDir, 'DEBIAN', 'control')
this.options.logger(`Creating control file at ${dest}`)

return common.wrapError('creating control file', async () => this.createTemplatedFile(src, dest))
return common.wrapError('creating control file', async () => {

await this.createTemplatedFile(src, dest);

const contrlDir = path.join(this.stagingDir, 'DEBIAN');
return fs.chmod(contrlDir, 0o755);
Copy link
Member

@malept malept Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit(spelling):

Suggested change
const contrlDir = path.join(this.stagingDir, 'DEBIAN');
return fs.chmod(contrlDir, 0o755);
const controlDir = path.join(this.stagingDir, 'DEBIAN');
return fs.chmod(controlDir, 0o755);

Copy link
Author

@belloyang belloyang Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I'm having difficulty creating a test for this. It would require to interfere in the .deb building process and update the control directory's permissions to 777. not sure if the test code is capable of doing it.

})
}

/**
Expand Down