Update playwright-screenshots script to work under rootless podman #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... thus making it possible to use `testcontainers` inside unprivileged containers.
Somebody wrote those `pushd` and `popd` lines without testing them. Redirections bind tighter than `||` so those lines were always spamming the console. Using `set -e` is more reliable than always checking exit codes anyway.
Thanks to a podman bug, the symlink workaround doesn't work there. Let's emit a noisy warning.
t3chguy
reviewed
Nov 5, 2025
richvdh
commented
Nov 6, 2025
packages/element-web-playwright-common/playwright-screenshots.sh
Outdated
Show resolved
Hide resolved
t3chguy
reviewed
Nov 6, 2025
t3chguy
reviewed
Nov 6, 2025
t3chguy
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to get this working correctly under rootless podman. See the individual commits for details.
Fixes: element-hq/element-web#31174