Introduce a hook to auto dispose view models #31178
Open
+109
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MidhunSureshR
force-pushed
the
midhun/shared-components/disposing-hook
branch
from
d0afe23 to
da048d1
Compare
dbkr
reviewed
Nov 5, 2025
| @@ -0,0 +1,47 @@ | |||
| /* | |||
| Copyright 2025 New Vector Ltd. | |||
Member
There was a problem hiding this comment.
I assume this probably should be Element Creations? (Also could do with a new line below)
| }; | ||
|
|
||
| // eslint-disable-next-line react-compiler/react-compiler | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Member
There was a problem hiding this comment.
which dep are we deliberately not including and why?
| * We want to be sure that whatever react component called this hook gets re-rendered | ||
| * when this happens, hence the state. | ||
| */ | ||
| const [viewModel, setViewModel] = useState<B>(vmCreator); |
Member
There was a problem hiding this comment.
Would a useRef be more appropriate maybe, since the view model isn't a thing that would need a re-render when it changes and so isn't really state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a hook that ties the lifecycle of the view-model to that of the calling react component.
We follow a bottom up approach in our MVVM refactors. As a consequence, we will have to create view-models in react components until we're done fully moving the code to our new architecture. This introduces the problem of how the view-models should be marked as disposed (i.e who actually calls
vm.dispose()).With this hook, you would:
Which would be the equivalent of