[POC] Signin with Element Classic

[bmarty]

Content

In order to let the user be able to migrate from Element Classic to Element X, we want Element X to propose the user to sign in using the existing session in Element Classic.

This PR does not contain the whole flow, but is introducing a way to let both application communicate together. We want to ensure that production application downloaded from the PlayStore are able to communicate together.

The UI is a temporary implementation, that's why no new strings have been added to Localazy yet.

Motivation and context

Part of element-hq/element-meta#3073

Screenshots / GIFs

Tests

• Sign in to a session to be able to enable the new feature flag "Sign in with Element Classic"
• Add a new account
• No new button should be displayed, except if a version of Element Classic having the expecting service and having a session is installed on the device. PR on Element Classic to be able to test the whole flow: Expose service to let Element X access some internal data element-android#9109

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HzNGWD

[jmartinesp]

LGTM. Following the flow is a bit difficult, but that's just how the Messenger pattern works.

[jmartinesp]

Nit: just stateFlow is good enough? This is a bit verbose 😅 . Up to you, though.

[bmarty]

f645922

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ElementBot]

• ⚠️ This Handler class should be static or leaks might occur (io.element.android.features.login.impl.screens.onboarding.classic.DefaultElementClassicConnection.IncomingHandler)

[codecov]

Codecov Report

❌ Patch coverage is 43.47826% with 104 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.28%. Comparing base (0dfdafd) to head (f645922).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ens/onboarding/classic/ElementClassicConnection.kt	2.29%	85 Missing ⚠️
...es/login/impl/screens/onboarding/OnBoardingView.kt	33.33%	16 Missing and 2 partials ⚠️
.../android/libraries/featureflag/api/FeatureFlags.kt	83.33%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6013      +/-   ##
===========================================
- Coverage    81.38%   81.28%   -0.11%     
===========================================
  Files         2550     2556       +6     
  Lines        68272    68456     +184     
  Branches      8759     8783      +24     
===========================================
+ Hits         55564    55644      +80     
- Misses        9455     9557     +102     
- Partials      3253     3255       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.