fix: download file on SamsungBrowser with block auto download (fixes #660)#661
Open
hudovisk wants to merge 1 commit intoeligrey:masterfrom
Open
fix: download file on SamsungBrowser with block auto download (fixes #660)#661hudovisk wants to merge 1 commit intoeligrey:masterfrom
hudovisk wants to merge 1 commit intoeligrey:masterfrom
Conversation
|
Pardon my question, but what is the purpose of the |
|
Hello any update on this? will this be released yet? Also does this really fix it? I guess not I have tried something similar locally and same result it fails to download while block automatic downloads is on. |
|
This needs to change to use window.open which works with Samsung Browser.. window.open(blob) though the file name will be lost but it will work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SamsungBrowser has a settings enabled by default called "Block automatic downloads" that basically blocks all downloads that are not initiated by user interaction, thus making the call
setTimeout(function () { click(a) }, 0)impossible to download a file on this browser, only if the user disables the settings option.By checking the user agent for SamsungBrowser and calling
click(a)instead ofsetTimeout(function () { click(a) }, 0)the function saveAs work as expected when called from an event initiated by the user. (button click)Tested on SamsungBrowser 12.0.1.47 with a Smasung S6 SM-G920I.
Code used to test:
Fixes #660