Skip to content

Do not modify column type while modifying fk constraint #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 23, 2024
Merged

Do not modify column type while modifying fk constraint #644

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
70a375f
Do not modify column type while modifying fk constraint
milmazz Oct 17, 2024
475cf8c
avoid alter column type on modify if not needed
milmazz Oct 17, 2024
fc2e173
should be smarter now?
milmazz Oct 18, 2024
daeed39
fix syntax error bug when setting default value
milmazz Oct 21, 2024
79e6479
minor refactor
milmazz Oct 21, 2024
609d4c1
Update docs and add a warning block for this function
milmazz Oct 21, 2024
6b90290
minor doc update
milmazz Oct 21, 2024
fb1655e
Apply suggestions from code review
milmazz Oct 23, 2024
c18c93f
add unit test for postgresql adapter
milmazz Oct 23, 2024
38e9365
revert unit tests modifications in sql/migration
milmazz Oct 23, 2024
ff60dd3
add unit tests to pg adapter
milmazz Oct 23, 2024
d951e49
update docs, minor unit test change
milmazz Oct 23, 2024
ce83d5a
update unit test
milmazz Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/ecto/adapters/postgres/connection.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,11 +1548,7 @@ if Code.ensure_loaded?(Postgrex) do
defp column_change(table, {:modify, name, %Reference{} = ref, opts}) do
[
drop_reference_expr(opts[:from], table, name),
"ALTER COLUMN ",
quote_name(name),
" TYPE ",
reference_column_type(ref.type, opts),
", ADD ",
"ADD ",
reference_expr(ref, table, name),
modify_null(name, opts),
modify_default(name, ref.type, opts)
Expand Down