Fix typespec #198
Merged
Fix typespec #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Good call, thank you! Could you revert unrelated changes? I'm happy to support geo ~> 4.0 but I'd prefer that as a distinct change. I can also merge the PR without squashing if you'd rather do that but then please clean up the commit history.
I'm not sure about changing CI matrix, I believe mysql 8.0.x series is still being developer, for example, so I'd want to test against that just in case. I'm happy to go over changing CI matrix in a separate PR.
|
Oh, I forgot there was a PR about geo already, I just merged it, please rebase. |
update script for newer docker formats update workflow update grid for CI tests
remove comment update DB lang pairs revert some changes from master
iacutone
force-pushed
the
fix-typespec
branch
from
1201950 to
d2e2d86
Compare
|
Thank you! Could you send similar PR to Postgrex? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typespec for
MyXQL.start_link/1is incorrect. This function wrapsDBConnection.start_link/2which has aGenServer.on_start()type.I'd like to introduce an accurate type for
MyXQL.start_link/1.